Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gpu: Check index buffer contents in pre-draw validation #8390

Closed
wants to merge 1 commit into from
Closed

gpu: Check index buffer contents in pre-draw validation #8390

wants to merge 1 commit into from

Conversation

arno-lunarg
Copy link
Contributor

This involves splitting up draw.vert into separate shaders for non-indexed indirect, indexed (both indirect and direct) and mesh draw calls.

Fixes #2492

Takeover of #8374

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build queued with queue ID 235204.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 17235 running.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 17235 failed.

@arno-lunarg arno-lunarg force-pushed the jeremyg-issue-2492-arno-takeover branch from 67ff959 to fd882c7 Compare August 13, 2024 17:35
@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build queued with queue ID 235229.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 17236 running.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 17236 failed.

@arno-lunarg arno-lunarg force-pushed the jeremyg-issue-2492-arno-takeover branch from fd882c7 to f6d63eb Compare August 14, 2024 06:33
@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build queued with queue ID 235543.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 17239 running.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 17239 failed.

@jeremyg-lunarg
Copy link
Contributor

I think I may have a slightly better version of this code to push still, I will push to my PR and you can figure out if that's really the case.

@arno-lunarg arno-lunarg force-pushed the jeremyg-issue-2492-arno-takeover branch from f6d63eb to fb6b478 Compare August 16, 2024 14:10
@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build queued with queue ID 236920.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 17248 running.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 17248 failed.

@arno-lunarg arno-lunarg force-pushed the jeremyg-issue-2492-arno-takeover branch from fb6b478 to f446338 Compare August 19, 2024 07:07
@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build queued with queue ID 238365.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 17264 running.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 17264 failed.

@jeremyg-lunarg @arno-lunarg
gpu: Check index buffer contents in pre-draw validation
37ae96d 
This involves splitting up draw.vert into separate shaders for
non-indexed indirect, indexed (both indirect and direct) and mesh
draw calls.

Fixes KhronosGroup#2492
@arno-lunarg arno-lunarg force-pushed the jeremyg-issue-2492-arno-takeover branch from f446338 to 37ae96d Compare August 19, 2024 07:40
@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build queued with queue ID 238389.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 17265 running.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 17265 failed.

@arno-lunarg
Copy link
Contributor Author

closing for now, still WIP and no need to run through CI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GPU-AV check index buffer out-of-bounds
3 participants
@arno-lunarg @ci-tester-lunarg @jeremyg-lunarg