Skip to content
This repository has been archived by the owner on Aug 4, 2024. It is now read-only.

feat: support check_key_conflict for mvcc #58

Merged
merged 3 commits into from
Dec 3, 2023
Merged

Conversation

KKould
Copy link
Member

@KKould KKould commented Nov 30, 2023

What problem does this PR solve?

Refer to RocksDB's optimistic write conflict implementation and perform conflict key checking during Transaction submission

Tips: This feature is mainly designed to solve the key conflict problem during DDL or Index maintenance in KipSQL

What is changed and how it works?

Code changes

  • Has Rust code change
  • Has CI related scripts change

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Note for reviewer

Copy link

Seems you are using me but didn't get OPENAI_API_KEY seted in Variables/Secrets for this repo. you could follow readme for more information

@KKould KKould added the enhancement New feature or request label Dec 1, 2023
@KKould KKould self-assigned this Dec 1, 2023
src/kernel/lsm/mvcc.rs Outdated Show resolved Hide resolved
Copy link

github-actions bot commented Dec 2, 2023

Seems you are using me but didn't get OPENAI_API_KEY seted in Variables/Secrets for this repo. you could follow readme for more information

Copy link

github-actions bot commented Dec 2, 2023

Seems you are using me but didn't get OPENAI_API_KEY seted in Variables/Secrets for this repo. you could follow readme for more information

@KKould KKould merged commit 9d09561 into master Dec 3, 2023
7 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant