Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
motivation: inconsistency in how the fetch errors were being parsed and evaluated, eg json is parsed twice in order to get the error message in one place but not another.
goal: type the output of insomniaFetch when a known backend error message is returned, and flatten the try catch if else nesting complexity of insomniaFetch
options:
Promise<T> | Promise<{message:string,errorType:string}>
This PR is meant to push this discussion with: @yaoweiprc @gatzjames
Using the exception and wrapping it has some rough edges in nodejs/chromium space because they dont both have error cause implementations.
TODO: