Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(api): Flatten ScoreComponent to empty string if score value is null #954

Merged
merged 1 commit into from
Jul 27, 2023
Merged

fix(api): Flatten ScoreComponent to empty string if score value is null #954

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion api/src/main/java/net/kyori/adventure/text/flattener/ComponentFlattenerImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,11 @@ final class ComponentFlattenerImpl implements ComponentFlattener {
@SuppressWarnings("deprecation")
static final ComponentFlattener BASIC = new BuilderImpl()
.mapper(KeybindComponent.class, component -> component.keybind()) // IntelliJ is wrong here, this is fine
.mapper(ScoreComponent.class, ScoreComponent::value) // Removed in Vanilla 1.16, but we keep it for backwards compat
.mapper(ScoreComponent.class, component -> {
// Removed in Vanilla 1.16, but we keep it for backwards compat
final @Nullable String value = component.value();
return value != null ? value : "";
})
.mapper(SelectorComponent.class, SelectorComponent::pattern)
.mapper(TextComponent.class, TextComponent::content)
.mapper(TranslatableComponent.class, component -> {
Expand Down