-
Notifications
You must be signed in to change notification settings - Fork 433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement grpc request scope #198
base: master
Are you sure you want to change the base?
Conversation
5fa83b7
to
2d0be5f
Compare
@jvmlet can you take a look at this? |
Did you ask the author of this feature if he is OK with copying the implementation as is? |
The copyright notice in the code gives explicit permission to copy it, but I can attempt to reach out |
I have reached out here: #177 (comment) |
I consent to my code being ported over. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me (I haven't tested it though).
I have now tagged you in the PR description @ST-DDT . I wasn't able to before you approved/commented on the PR since you weren't a contributor on this project. |
FFR: It is possible even without that, but auto completion does not work. |
@jvmlet I got the permission and approval. Let me know if this is ok |
@jvmlet can you take another look? |
@jvmlet Can you please review this? I would still like to get this in |
Can you please merge it? |
@jvmlet is there any update? |
This is to port over the grpc request scope added in https://github.com/yidongnan/grpc-spring-boot-starter in the following PR https://github.com/yidongnan/grpc-spring-boot-starter/pull/259 (by @ST-DDT)