Add a function to get the full-size of xg and yg from input files #195
Conversation
|
what was wrong with get_grid_from_input ? Line 1247 in 1fb9cc2 |
|
It doesn't do what I want - it doesn't get the rightmost gridpoints. Also it doesn't tile in the way that I want |
There was a problem hiding this comment.
Thanks for looking into this @cspencerjones. I appreciate that the existing get_grid_from_inputs function did not work for the reasons you stated. However, I would strongly prefer that we modify that function to meet your needs, rather than introduce a new one with much of the same code.
I see two separate features here:
- The ability to get the extra "outer" grid point from the mitgrid files. This could be an optional flag to
get_grid_from_inputs, maybeouter=Falseas a default, to keep backwards compatibility - The ability to reshape a dataset in tiles of a specified shape.
Could we do these as two separate functions, or is there some fundamental reason why they need to be in a single function?
| blankList=bl) | ||
| # test types | ||
| assert type(ds) == xarray.Dataset | ||
| assert type(ds['XG']) == xarray.core.dataarray.DataArray |
|
@cspencerjones - are you planning to continue to work on this? |
|
It's not my priority. If we think that these changes would be useful for other people then I can but I'm not sure that there is actually need for them right now. So probably no, I will just keep using my own branch. Do you have a strong opinion? |
|
Hi @cspencerjones, |
|
@AaronDavidSchneider I do not have time to work on this at the moment, since my project has moved away from this problem, at least temporarily. The code is quite dense and hard to follow, and as @rabernat mentions above my new code actually repeats a lot of what's in the original function. However you are welcome to take it and see how it works for you. If it does, then maybe you could contribute to this pull request as well? |
|
Yes it would be great if @AaronDavidSchneider would be able to pick up this PR! We will be happy to help you. From a technical standpoint, it is probably easiest for you to check out @cspencerjones's branch and make a new PR from your own fork. |
That sounds good. I will try my best to get it working. I am not quite sure when I will have the time for it. |
This function gets XG and YG from .mitgrid files. They are the full size (i.e. they include the points on the right hand side of the final gridpoint in both x and y directions. This is useful if you want to determine which tile and individual lat/lon point is on.