Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MRG] redesign mle chat #224

Merged
merged 3 commits into from
Sep 27, 2024
Merged

[MRG] redesign mle chat #224

merged 3 commits into from
Sep 27, 2024

Conversation

leeeizhang
Copy link
Collaborator

@leeeizhang leeeizhang commented Sep 25, 2024 •
edited
Loading

Closes #205

  • add chat workflow
  • support chatbot greeting
  • streaming display
  • conversation resume when re-enter the mle chat

@leeeizhang leeeizhang self-assigned this Sep 25, 2024
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. enhancement New feature or request labels Sep 25, 2024
@leeeizhang leeeizhang changed the title [WIP] redesign mle chat [MRG] redesign mle chat Sep 27, 2024
huangyz0918
huangyz0918 approved these changes Sep 27, 2024
View reviewed changes
Copy link
Contributor

@huangyz0918 huangyz0918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 27, 2024
@huangyz0918 huangyz0918 merged commit 6f378d6 into MLSysOps:main Sep 27, 2024
3 checks passed
@leeeizhang leeeizhang deleted the lei/redesign-chat branch September 27, 2024 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huangyz0918 huangyz0918 huangyz0918 approved these changes

Assignees

@leeeizhang leeeizhang

Labels
enhancement New feature or request lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[mle chat] cli should be redesiged
2 participants
@leeeizhang @huangyz0918