x64: brgemm: fix coverity

MOLOjl · Jun 6, 2024 · e5f0384 · e5f0384
1 parent 1d0e97f
commit e5f0384
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 3 deletions.
diff --git a/src/cpu/x64/brgemm/brgemm.cpp b/src/cpu/x64/brgemm/brgemm.cpp
@@ -540,7 +540,7 @@ status_t brgemm_desc_set_attr(
     brg->is_blocked = (brg->LDA2 != brg->LDA || brg->LDB2 != brg->LDB
             || brg->LDC2_M != brg->LDC || brg->LDC2_N != brg->ld_block);
 
-    if (!IMPLICATION(brg->is_blocked, brg->layout = brgemm_row_major))
+    if (!IMPLICATION(brg->is_blocked, brg->layout == brgemm_row_major))
         return status::invalid_arguments;
 
     // virtual padding is not supported for "amx"

diff --git a/src/cpu/x64/brgemm/brgemm_types.hpp b/src/cpu/x64/brgemm/brgemm_types.hpp
@@ -343,7 +343,8 @@ struct brgemm_desc_t {
 
     int get_A_tensor(int m, bool m_tail = false) const noexcept {
         const auto full_A_tiles = get_num_A_tiles() - (bdb_tail ? 1 : 0);
-        auto M = m_tail ? get_num_A_tiles() - 1 : m % full_A_tiles;
+        auto M = (m_tail || full_A_tiles == 0) ? get_num_A_tiles() - 1
+                                               : m % full_A_tiles;
         return (get_num_C_tiles() + M);
     }
 
@@ -358,7 +359,8 @@ struct brgemm_desc_t {
 
     int get_B_tensor(int n, bool n_tail = false) const noexcept {
         const auto full_B_tiles = get_num_B_tiles() - (ldb_tail ? 1 : 0);
-        auto N = n_tail ? get_num_B_tiles() - 1 : n % full_B_tiles;
+        auto N = (n_tail || full_B_tiles == 0) ? get_num_B_tiles() - 1
+                                               : n % full_B_tiles;
         return (get_num_C_tiles() + get_num_A_tiles() + N);
     }
 

diff --git a/src/cpu/x64/brgemm/brgemm_utils.cpp b/src/cpu/x64/brgemm/brgemm_utils.cpp
@@ -272,6 +272,7 @@ status_t brgemm_blocking(brgemm_desc_t *brg) {
         const int rd_unroll = 4;
         const data_type_t rd_block_dt = get_mac_emu_data_type(
                 brg->dt_a, brg->isa_impl, brg->isa_impl != avx2_vnni_2);
+        if (rd_block_dt == dnnl_data_type_undef) return status::unimplemented;
         const int vnni_granularity = data_type_vnni_granularity(rd_block_dt);
         brg->rd_block = rd_unroll * vnni_granularity;
         brg->rdb = brg->reduce_dim / brg->rd_block;