Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Pass GHA default environment variables #95

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

agrare
Copy link
Member

@agrare agrare commented Aug 26, 2022

We have some scripts which require the use of some default environment variables passed in by GitHub Actions (e.g.: https://github.com/ManageIQ/manageiq/blob/master/bin/before_install#L25). When run via cross-repo these scripts get the GHA env vars for the cross-repo run not what they would get for the test_repo.

@agrare agrare force-pushed the pass_github_actions_default_env_vars branch 4 times, most recently from 79bf97e to 8629378 Compare August 29, 2022 15:33
"MANAGEIQ_REPO" => core_repo.path.to_s,
"BUNDLE_PATH" => bundle_path.to_s,
"TEST_SUITE" => test_suite,
"CI" => "true",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alignment here is weird - was that intentional?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh nvm - didn't realize this was WIP.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup just trying to get it to work, haven't figured out a good way of determining the base_ref yet without hitting the github api so for now hard-coded to oparin

@agrare agrare closed this Aug 31, 2022
@agrare agrare reopened this Aug 31, 2022
@agrare agrare closed this Aug 31, 2022
@agrare agrare reopened this Aug 31, 2022
@Fryguy Fryguy added the bug Something isn't working label Aug 31, 2022
@Fryguy Fryguy self-assigned this Aug 31, 2022
@agrare agrare force-pushed the pass_github_actions_default_env_vars branch from 8629378 to 346bf1b Compare September 1, 2022 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants