Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

customize open/close tags via 'string-template/custom' #2

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

nenj
Copy link

@nenj nenj commented Nov 18, 2014

The main module is now exposing two methods, 'process' (formerly 'template') and 'setOpenCloseTags'
The one-function structure of module.exports is thus changed, maybe requiring a version increment...
As you consider best, Matt.

The main module is now exposing two methods, 'process' (formerly 'template') and 'setOpenCloseTags'
@coveralls
Copy link

Coverage Status

Coverage decreased (-2.04%) when pulling eadd4de on nenj:master into 8f28bb1 on Matt-Esch:master.

@Matt-Esch
Copy link
Owner

I think it is good to be able to set the tags, but it probably should not be exposed like this. I suggest that we keep the same default expectation i.e. index.js exports a format function which defaults to '{' and '}'. Then maybe you can require string-template/custom to expose the tag options. index.js would rely on this underlying implementation.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling edba0b9 on nenj:master into 8f28bb1 on Matt-Esch:master.

@nenj nenj changed the title enable customizing open/close container tags. customize open/close tags via 'string-template/custom' Nov 19, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants