Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model Variable Naming Sprint: Part 7 #228

Merged
merged 4 commits into from
Oct 9, 2024

Conversation

mikecooke77
Copy link
Collaborator

@mikecooke77 mikecooke77 commented Oct 8, 2024

Description

Part of https://github.com/JCSDA-internal/oops/issues/2737

Renames the following variables:

  • surface_pressure_at_mean_sea_level -> air_pressure_at_sea_level
  • surface_eastward_wind -> eastward_wind_at_surface
  • surface_northward_wind -> northward_wind_at_surface
  • uwind_at_10m -> eastward_wind_at_10m
  • vwind_at_10m -> northward_wind_at_10m
  • eastward_wind_10m -> eastward_wind_at_10m
  • northward_wind_10m -> northward_wind_at_10m
  • surface_wind_from_direction -> wind_from_direction_at_surface
  • surface_wind_speed -> wind_speed_at_surface

Dependencies

build-group=https://github.com/JCSDA-internal/fv3-jedi/pull/1280
build-group=https://github.com/JCSDA-internal/vader/pull/277
build-group=JCSDA-internal/ufo-data#452
build-group=https://github.com/JCSDA-internal/ufo/pull/3484
build-group=https://github.com/JCSDA-internal/ops-um-jedi/pull/236
build-group=https://github.com/MetOffice/jjtests/pull/49
build-group=https://github.com/JCSDA-internal/lfric-jedi/pull/909

To be merged with this PR

Checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have run the unit tests before creating the PR

@mikecooke77 mikecooke77 merged commit 17a321b into develop Oct 9, 2024
5 checks passed
@mikecooke77 mikecooke77 deleted the feature/variable_names_part7 branch October 9, 2024 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants