Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Stratis provhdr #803

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Conversation

zeptin
Copy link
Contributor

@zeptin zeptin commented Jan 16, 2020

Also tweaked some altcoin tests to allow them to pass more consistently on multiple networks.

NBitcoin/RPC/RPCClient.cs Outdated Show resolved Hide resolved
{
//var builder = NodeBuilder.Create(NodeDownloadData.Litecoin.v0_17_1, Altcoins.Litecoin.Instance.Regtest, caller);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please don't edit that

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original method still exists below. It merely calls the two new methods that split out the network set and node data into two reusable methods (e.g. note that some of the altcoin tests need to know which network they are running against, for some reason)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no point in doing that, now we need to modify 2 distinct places when 99% of the time we just want to uncomment 1 line.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you suggest an improved way of determining which network set is in effect in the tests? It is necessary to inhibit certain tests from running when they are not running against the intended network (e.g. Liquid). If this is not done, at least one spurious test failure results across all other networks, which feels sloppy.

@NicolasDorier
Copy link
Collaborator

It does not build on appveyor.

@zeptin
Copy link
Contributor Author

zeptin commented Feb 19, 2020

It does not build on appveyor.

It seems like this would only happen if NOSOCKET is set on appveyor, which would render any of the tests involving the protocol inoperative. That would appear to defeat the point of having the tests?

@NicolasDorier
Copy link
Collaborator

then surround the test with NOSOCKET

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants