-
Notifications
You must be signed in to change notification settings - Fork 848
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Stratis provhdr #803
base: master
Are you sure you want to change the base?
Conversation
{ | ||
//var builder = NodeBuilder.Create(NodeDownloadData.Litecoin.v0_17_1, Altcoins.Litecoin.Instance.Regtest, caller); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please don't edit that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The original method still exists below. It merely calls the two new methods that split out the network set and node data into two reusable methods (e.g. note that some of the altcoin tests need to know which network they are running against, for some reason)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no point in doing that, now we need to modify 2 distinct places when 99% of the time we just want to uncomment 1 line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you suggest an improved way of determining which network set is in effect in the tests? It is necessary to inhibit certain tests from running when they are not running against the intended network (e.g. Liquid). If this is not done, at least one spurious test failure results across all other networks, which feels sloppy.
It does not build on appveyor. |
It seems like this would only happen if |
then surround the test with NOSOCKET |
878114e
to
24301c6
Compare
Also tweaked some altcoin tests to allow them to pass more consistently on multiple networks.