Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sc-29652] Skip SystemDescription if comment is empty string #1029

Conversation

usefulalgorithm
Copy link
Contributor

🤔 Why?

A SystemDescription with empty string as description Metaphor ingestion, we should only populate it if the comment is a non-empty string.

🤓 What?

As titled.

🧪 Tested?

Tested against our stage environment.

☑️ Checks

  • My PR contains actual code changes, and I have updated the version number in pyproject.toml.

Copy link

github-actions bot commented Nov 1, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
13402 11969 89% 85% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
metaphor/unity_catalog/extractor.py 95% 🟢
TOTAL 95% 🟢

updated for commit: 4ecc3a4 by action🐍

Copy link

codecov bot commented Nov 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@6e6bb7f). Learn more about missing BASE report.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1029   +/-   ##
=======================================
  Coverage        ?   89.30%           
=======================================
  Files           ?      205           
  Lines           ?    13402           
  Branches        ?        0           
=======================================
  Hits            ?    11969           
  Misses          ?     1433           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@usefulalgorithm usefulalgorithm merged commit 5f381a1 into main Nov 1, 2024
6 checks passed
@usefulalgorithm usefulalgorithm deleted the tsung-julii/sc-29652/alert-an-error-of-type-programmatic-error branch November 1, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants