Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config to disable queries that require SELECT permission #1030

Merged
merged 1 commit into from
Nov 4, 2024
Merged

Conversation

mars-lan
Copy link
Contributor

@mars-lan mars-lan commented Nov 3, 2024

🤔 Why?

A few small fixed/improvements after #1022.

🤓 What?

  • Add has_select_permissions config to enable/disable all queries that require SELECT permission.
  • Avoid printing the full stack when encountering permission issues.
  • Properly handle empty descriptions.
  • Properly JSON-encode table property values.
  • Add files missed by [sc-2887] GX Crawler #1025

🧪 Tested?

Verified end-to-end against a production instance.

☑️ Checks

  • My PR contains actual code changes, and I have updated the version number in pyproject.toml.

Copy link

github-actions bot commented Nov 3, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
13408 11975 89% 85% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
metaphor/common/utils.py 98% 🟢
metaphor/unity_catalog/config.py 100% 🟢
metaphor/unity_catalog/extractor.py 95% 🟢
metaphor/unity_catalog/queries.py 97% 🟢
TOTAL 98% 🟢

updated for commit: 16e7bda by action🐍

Copy link

codecov bot commented Nov 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.31%. Comparing base (5f381a1) to head (16e7bda).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1030   +/-   ##
=======================================
  Coverage   89.30%   89.31%           
=======================================
  Files         205      205           
  Lines       13402    13408    +6     
=======================================
+ Hits        11969    11975    +6     
  Misses       1433     1433           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mars-lan mars-lan marked this pull request as ready for review November 4, 2024 03:45
@mars-lan mars-lan enabled auto-merge (squash) November 4, 2024 03:45
Copy link
Contributor

@elic-eon elic-eon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mars-lan mars-lan merged commit 658b20f into main Nov 4, 2024
6 checks passed
@mars-lan mars-lan deleted the unity branch November 4, 2024 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants