Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OpenAPI hierarchy #1037

Merged
merged 2 commits into from
Nov 6, 2024
Merged

Conversation

elic-eon
Copy link
Contributor

@elic-eon elic-eon commented Nov 6, 2024

🤔 Why?

APIs without tags have empty hierarchy but they should belongs to top-level OpenAPI hierarchy

https://app.shortcut.com/metaphor-data/story/29745

🤓 What?

  • Fix directories logic

🧪 Tested?

Add unit tests.

☑️ Checks

  • My PR contains actual code changes, and I have updated the version number in pyproject.toml.

Copy link
Contributor

@usefulalgorithm usefulalgorithm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@elic-eon elic-eon enabled auto-merge (squash) November 6, 2024 08:43
Copy link

github-actions bot commented Nov 6, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
13438 11999 89% 85% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
metaphor/openapi/extractor.py 93% 🟢
TOTAL 93% 🟢

updated for commit: dd6e00b by action🐍

@elic-eon elic-eon merged commit 5d8944e into main Nov 6, 2024
4 checks passed
@elic-eon elic-eon deleted the scotthuang/sc-29745/fix-openapi-hierarchy branch November 6, 2024 08:49
Copy link

codecov bot commented Nov 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.29%. Comparing base (cc34d58) to head (dd6e00b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1037   +/-   ##
=======================================
  Coverage   89.28%   89.29%           
=======================================
  Files         206      206           
  Lines       13438    13438           
=======================================
+ Hits        11998    11999    +1     
+ Misses       1440     1439    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants