Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Top level folders for QuickSight entities #988

Merged
merged 2 commits into from
Sep 24, 2024

Conversation

elic-eon
Copy link
Contributor

@elic-eon elic-eon commented Sep 24, 2024

🤔 Why?

To place QuickSight dashboards and datasets in the predefined folders.

🤓 What?

  • Fill structure.directories
  • Refactor create_hierarchy

🧪 Tested?

Updated unit tests and verified end-to-end on dev.

☑️ Checks

  • My PR contains actual code changes, and I have updated the version number in pyproject.toml.

Copy link

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
12591 11256 89% 85% 🟢

New Files

File Coverage Status
metaphor/common/hierarchy.py 100% 🟢
metaphor/quick_sight/folder.py 100% 🟢
TOTAL 100% 🟢

Modified Files

File Coverage Status
metaphor/looker/folder.py 93% 🟢
metaphor/quick_sight/extractor.py 95% 🟢
metaphor/thought_spot/extractor.py 91% 🟢
metaphor/thought_spot/utils.py 97% 🟢
TOTAL 94% 🟢

updated for commit: 4a4f478 by action🐍

Copy link

codecov bot commented Sep 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.39%. Comparing base (167ccb7) to head (4a4f478).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #988      +/-   ##
==========================================
+ Coverage   89.38%   89.39%   +0.01%     
==========================================
  Files         191      193       +2     
  Lines       12575    12591      +16     
==========================================
+ Hits        11240    11256      +16     
  Misses       1335     1335              
Flag Coverage Δ
89.39% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@elic-eon elic-eon merged commit 026c102 into main Sep 24, 2024
6 checks passed
@elic-eon elic-eon deleted the scotthuang/sc-28907/top-level-folders-for-entities branch September 24, 2024 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants