Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sc-27944] Add config to disable tag collection in Snowflake #992

Merged

Conversation

usefulalgorithm
Copy link
Contributor

🤔 Why?

To reduce the amount of notifications on platform tag changes, a config is added to Snowflake to disable tag collection. Users can have 2 Snowflake crawlers that do different things: one is the full-scale crawler, crawls the query logs and the tags; the other is the lightweight one, doesn't do query logs or collect tags.

🤓 What?

Added a config value to disable collecting tags in Snowflake.

🧪 Tested?

Crawler run locally.

☑️ Checks

  • My PR contains actual code changes, and I have updated the version number in pyproject.toml.

Copy link

github-actions bot commented Oct 1, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
12809 11458 89% 85% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
metaphor/snowflake/config.py 100% 🟢
metaphor/snowflake/extractor.py 85% 🟢
TOTAL 92% 🟢

updated for commit: 199c8f3 by action🐍

Copy link

codecov bot commented Oct 1, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 89.45%. Comparing base (c58fb73) to head (199c8f3).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
metaphor/snowflake/extractor.py 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #992      +/-   ##
==========================================
- Coverage   89.45%   89.45%   -0.01%     
==========================================
  Files         196      196              
  Lines       12806    12809       +3     
==========================================
+ Hits        11456    11458       +2     
- Misses       1350     1351       +1     
Flag Coverage Δ
89.45% <60.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@alyiwang alyiwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@usefulalgorithm usefulalgorithm merged commit 576d867 into main Oct 1, 2024
4 of 6 checks passed
@usefulalgorithm usefulalgorithm deleted the tsung-julii/sc-27944/config-to-disable-tag-collection branch October 1, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants