Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove R1CS_constraint_system from snarky #12130

Draft
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

mrmr1993
Copy link
Member

@mrmr1993 mrmr1993 commented Nov 7, 2022

This PR is the mina-side counterpart to o1-labs/snarky#674. This removes an unnecessary part of the interface.

Checklist:

  • Modified the current draft of release notes with details on what is completed or incomplete within this project
  • Document code purpose, how to use it
    • Mention expected invariants, implicit constraints
  • Tests were added for the new behavior
    • Document test purpose, significance of failures
    • Test names should reflect their purpose
  • All tests pass (CI will check this if you didn't)
  • Serialized types are in stable-versioned modules
  • Does this close issues? List them

@mrmr1993 mrmr1993 requested review from a team as code owners November 7, 2022 20:01
@mimoo
Copy link
Contributor

mimoo commented Nov 7, 2022

nice and clean!

Base automatically changed from feature/add-plonk_constraint_system-intf to develop November 8, 2022 16:10
@mrmr1993
Copy link
Member Author

!ci-build-me

@mrmr1993 mrmr1993 self-assigned this Nov 28, 2022
@mrmr1993 mrmr1993 marked this pull request as draft January 10, 2024 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants