-
Notifications
You must be signed in to change notification settings - Fork 529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Coherent IT config passing #16137
base: compatible
Are you sure you want to change the base?
Coherent IT config passing #16137
Conversation
b8f5e97
to
52d8ecc
Compare
4c54643
to
7a73517
Compare
781ba91
to
eab6fb2
Compare
!ci-nightly-me |
eab6fb2
to
c73837f
Compare
!ci-nightly-me |
f57a438
to
11b5fbc
Compare
!ci-nightly-me |
c757bf2
to
6fbc7fe
Compare
8a72934
to
7052864
Compare
7052864
to
24ab32f
Compare
!ci-nightly-me |
Some Runtime_config.Proof_keys.Transaction_capacity.small | ||
} | ||
; work_delay = 1 | ||
; transaction_capacity_log_2 = 2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit
i have a slight preference for modifying the type and using the variable.
Some Runtime_config.Proof_keys.Transaction_capacity.small | ||
} | ||
; work_delay = 1 | ||
; transaction_capacity_log_2 = 2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit
slight preference for modifying type and changing transaction_capacity_log_2 to a the variable.
Some Runtime_config.Proof_keys.Transaction_capacity.small | ||
} | ||
; work_delay = 1 | ||
; transaction_capacity_log_2 = 2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit
same as above
Some Runtime_config.Proof_keys.Transaction_capacity.medium | ||
} | ||
; work_delay = 1 | ||
; transaction_capacity_log_2 = 3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto
I came across this while working on a separate issue, but there are places within the integration-tests that we are not apply configuration consistently.
The way things work now
The way that config is built up and stored is sort of complicated, but basically the gist is:
Runtime_config.t
expand
function takes argumentstest_config
andconstants
and defines aruntime_config : Runtime_config.t
constants : Test_config.constants
value which is accessed in subsequent portions of the test. This is supposed to reflect all of the changes made to the initial configuration. It also stores a json representation of the constructedruntime_config
value, presumably to load it in when the test boots up.This PR fixes...
In
(2)
above, we are not using exhaustive pattern matching on thetest_config
value, so the wildcard will discard overrides toruntime_config
unless you remember to update it here as well (trust me, this can happen). I introduced exhaustive matching here to fix this. I made additional simplifications to thetest_config
structure REproof_config
. E.g. there were duplicate entries forblock_window_duration_ms
andtransaction_capacity_log_2
In
(3)
above, we are discarding someruntime_conifg
overrides for the when updating theconstants
. This is no longer the case.