Remove berkeley codename from CI #16160
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_to_develop_0208 merge compatible to develop 02/08
…_deb_dev [DEV] Removed Test executive dockers and buster debian
…keley remove connect to berkeley test
swapping out the s3 bucket link for snark-keys
normalizing snarky yojson serializers to match kimchi common
…a/port_patch_archive_test_dev
…berkeley_removal port compatible berkeley removal to dev
…ve_test_dev [Dev] Port Patch archive test again
[Dev] Update logo and description for README.md
Still getting the following warnings/errors:
```
In scripts/debian/build.sh line 12:
BRANCH_NAME="${BRANCH_NAME}" source "${SCRIPTPATH}"/../export-git-env-vars.sh
^-- SC1091 (info): Not following: ./../export-git-env-vars.sh was not specified as input (see shellcheck -x).
In scripts/debian/build.sh line 14:
source "${SCRIPTPATH}"/../export-git-env-vars.sh
^-- SC1091 (info): Not following: ./../export-git-env-vars.sh was not specified as input (see shellcheck -x).
In scripts/debian/build.sh line 19:
source "${SCRIPTPATH}"/builder-helpers.sh
^-- SC1091 (info): Not following: ./builder-helpers.sh was not specified as input (see shellcheck -x).
```
I am still getting:
```
In scripts/debian/publish.sh line 60:
) && break || scripts/debian/clear-s3-lockfile.sh; done
^-- SC2015 (info): Note that A && B || C is not if-then-else. C may run when A is true.
In scripts/debian/publish.sh line 80:
for _i in {1..10}; do (verify_o1test_repo_has_package "${deb}") && break || sleep 60; done
^-- SC2015 (info): Note that A && B || C is not if-then-else. C may run when A is true.
For more information:
https://www.shellcheck.net/wiki/SC2015 -- Note that A && B || C is not if-t...
```
I am still getting the following message:
```
In scripts/debian/reversion.sh line 63:
source scripts/debian/publish.sh --names "${NEW_NAME}_${NEW_VERSION}.deb" --version "${NEW_VERSION}" --codename "${CODENAME}" --release "${NEW_RELEASE}"
^-----------------------^ SC1091 (info): Not following: scripts/debian/publish.sh was not specified as input (see shellcheck -x).
For more information:
https://www.shellcheck.net/wiki/SC1091 -- Not following: scripts/debian/pub...
```
I am still getting: ``` In scripts/debian/verify.sh line 47: && echo 'OK: ALL WORKED FINE!' || (echo 'KO: ERROR!!!' && exit 1) ^-- SC2015 (info): Note that A && B || C is not if-then-else. C may run when A is true. For more information: https://www.shellcheck.net/wiki/SC2015 -- Note that A && B || C is not if-t... ```
…witches-develop reformat: ignore opam-switches [develop]
…elop [easy/develop] Make shellcheck happier on scripts/debian/*.sh
…4-09-26 Merge back to develop
|
!ci-build-me |
dkijania
changed the title
|
!ci-build-me |
dkijania
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port CI fixes from dev: