Introduce additional checks for dhall (deps, dirtyWhen) #16168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
!ci-build-me |
This reverts commit 35f9de53f244c91656d101cb4b523deb6985367c.
This reverts commit 561a5b889757092f8d9c4e21605b96d36dc53828.
|
!ci-build-me |
|
!ci-build-me |
|
!ci-build-me |
|
!ci-build-me |
|
!ci-build-me |
|
!ci-build-me |
|
|
||
| check_deps: | ||
| $(eval TMP := $(shell mktemp -d)) |
There was a problem hiding this comment.
This white space is killing my OCD-eyes.
|
!ci-build-me |
|
!ci-build-me |
|
!ci-build-me |
|
!ci-build-me |
SanabriaRusso
approved these changes
Oct 18, 2024
|
!ci-build-me |
|
!ci-build-me |
|
!approved-for-mainnet |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introducing additional checks for dhall which will be used in ci but nothing prevents to use them locally. There are 3 new commands
Additionally I fixed all encountered issues with dirtyWhen and Dependencies
(all commands should be run in buildkite folder)
check dependencies
usage:
make check_depsdesc: it validates that if step provides dependsOn section it is a correct and existing key of some job
check dirtyWhen
usage:
make check_dirtydesc: it validates that if step provides dirtyWhen section it is corresponding to existing files
print cmd (only for local)
usage:
python3 buildkite/scripts/dhall/checker --root buildkite/src/Jobs print-cmd --job MinaArtifactFocal --step build_deb_pkgEDIT:
Currently there is peculiar issue with running dhall in toolchain:
https://buildkite.com/o-1-labs-2/mina-o-1-labs/builds/35531#01924994-aad4-47bf-a42c-ab8f1d89eaa1/74-99
I will solve it in different PR. As a result won't propagate new Ci jobs