Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling of gzip-encoded text response #2141

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

suriya
Copy link
Contributor

@suriya suriya commented Jul 25, 2020

When Zappa receives a compressed text/plain response from the
application, it tries to process it as a text response. Instead, Zappa
should treat the response as if it were a binary one and base-64 encode
the response body.

See issue #2080 binary_support logic in handler.py (0.51.0) broke compressed text response
#2080

Description

GitHub Issues

When Zappa receives a compressed text/plain response from the
application, it tries to process it as a text response. Instead, Zappa
should treat the response as if it were a binary one and base-64 encode
the response body.

See issue Miserlou#2080 binary_support logic in handler.py (0.51.0) broke compressed text response
Miserlou#2080
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 72.941% when pulling bfcb649 on suriya:gzip-encoded-response-handling-1 into 0c8d99d on Miserlou:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 72.941% when pulling bfcb649 on suriya:gzip-encoded-response-handling-1 into 0c8d99d on Miserlou:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants