Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extra subroutine for all_reduce_min_max in mpi utilites #766

Merged
merged 4 commits into from
Nov 8, 2024

Conversation

mjs2369
Copy link
Contributor

@mjs2369 mjs2369 commented Nov 5, 2024

Description:

Removed an unnecessary subroutine since all_reduce_min_max and broadcast_minmax were doing the work of a single subroutine.

Fixes issue

fixes #762

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Documentation changes needed?

  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.

Tests

Compiled and ran lorenz

Checklist for merging

  • Updated changelog entry
  • Documentation updated
  • Update conf.py

Checklist for release

  • Merge into main
  • Create release from the main branch with appropriate tag
  • Delete feature-branch

Testing Datasets

  • Dataset needed for testing available upon request
  • Dataset download instructions included
  • No dataset needed

… files (mpi_utilities_mod.f90, mpif08_utilities_mod.f90, null_mpi_utilities_mod.f90); reverting to the original name all_reduce_min_max as this is accurate to the content of the subroutine
@hkershaw-brown
Copy link
Member

hkershaw-brown commented Nov 6, 2024

Compiled and ran lorenz

lorenz doesn't call broadcast_minmax (or all_reduce_min_max) so this is not a great test for this pull request.
You can use the github action to run all quickbuild.sh: https://github.com/NCAR/DART/actions/workflows/run_all_quickbuilds.yml

@hkershaw-brown hkershaw-brown added release! bundle with next release release+1 bundle with release after next and removed release! bundle with next release release+1 bundle with release after next labels Nov 6, 2024
@hkershaw-brown hkershaw-brown merged commit 89c6fc1 into main Nov 8, 2024
4 checks passed
@hkershaw-brown hkershaw-brown deleted the all_reduce branch November 8, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release! bundle with next release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

all_reduce_min_max subroutine should be removed from the mpi_utilities_mod files
2 participants