Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

modified error handling for node annotator #642

Merged
merged 10 commits into from
Jul 15, 2024
Merged

modified error handling for node annotator #642

Changes from 5 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
29a2b3e
modified error handling for node annotator
Jun 28, 2024
71f363b
fixing the annotator url
Jun 28, 2024
4541601
added more logging for exceptions
Jun 28, 2024
23a2d16
added more logging for exceptions
Jun 28, 2024
af4bf2c
fixed annotator URL
Jun 28, 2024
3bd5b72
first draft in seperating the error codes
Jul 1, 2024
cc83044
added more precise logging for annatator & appraiser failing
Jul 2, 2024
35cb272
Merge branch 'master' into annotator_fail_code
ShervinAbd92 Jul 15, 2024
745c901
Merge remote-tracking branch 'origin/master' into annotator_fail_code
Jul 15, 2024
9429b06
resolved confilict
Jul 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
99 changes: 65 additions & 34 deletions tr_sys/tr_ars/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -551,36 +551,58 @@ def pre_merge_process(data,key, agent_name,inforesid):
logging.exception("Error in ARS score normalization")
raise e


def post_process(data,key, agent_name):
code =200
status='D'
mesg = get_object_or_404(Message.objects.filter(pk=key))
logging.info("Pre node annotation for agent %s pk: %s" % (agent_name, str(key)))
try:
annotate_nodes(mesg,data,agent_name)
logging.info("node annotation successful for agent %s and pk: %s" % (agent_name, str(key)))
except Exception as e:
post_processing_error(mesg,data,"Error in annotation of nodes")
logging.error("Error with node annotations for "+str(key))
logging.exception("problem with node annotation post process function")
raise e
status='E'
code=444
log_tuple =[
f'node annotation internal error: {str(e)}',
datetime.now().strftime('%H:%M:%S'),
"DEBUG"
]
add_log_entry(data,log_tuple)
logging.exception(f"problem with node annotation for agent: {agent_name} pk: {str(key)}")

logging.info("pre scrub null for agent %s and pk %s" % (agent_name, str(key)))
try:
scrub_null_attributes(data)
except Exception as e:
logging.info("Problem with the second scrubbing of null attributes")
status='E'
code=444
logging.exception(f"Problem with the second scrubbing of null attributes for agent: {agent_name} pk: {str(key)}")
post_processing_error(mesg,data,"Error in second scrubbing of null attributes")
log_tuple =[
"Error in second scrubbing of null attributes",
datetime.now().strftime('%H:%M:%S'),
"DEBUG"
]
add_log_entry(data,log_tuple)
logging.info("pre blocklist for "+str(key))
try:
remove_blocked(mesg, data)
except Exception as e:
status='E'
code=444
logging.info(e.__cause__)
logging.info("Problem with block list removal")
logging.exception(f"Problem with block list removal for agent: {agent_name} pk: {str(key)}")

mesg.status=status
mesg.code=code
mesg.save(update_fields=['status','code'])
logging.info("pre appraiser for agent %s and pk %s" % (agent_name, str(key)))
try:
appraise(mesg,data,agent_name)
logging.info("appraiser successful for agent %s and pk %s" % (agent_name, str(key)))
except Exception as e:
code = 422
mesg.status='E'
mesg.code = 422
results = get_safe(data,"message","results")
default_ordering_component = {
"novelty": 0,
Expand All @@ -595,11 +617,14 @@ def post_process(data,key, agent_name):
continue
else:
logging.error('results returned from appraiser is None')

#post_processing_error(mesg,data,"Error in appraiser")
logging.error("Error with appraise for "+str(key))
logging.exception("Error in appraiser post process function")
#raise e
log_tuple =[
"Error in Appraiser: "+ str(e),
datetime.now().strftime('%H:%M:%S'),
"ERROR"
]
add_log_entry(data,log_tuple)
mesg.save(update_fields=['status','code'])
raise e
try:
results = get_safe(data,"message","results")
if results is not None:
Expand All @@ -611,22 +636,38 @@ def post_process(data,key, agent_name):
logging.error('results from appraiser returns None, cant do the scoring')
print()
except Exception as e:
mesg.status='E'
mesg.code = 422
post_processing_error(mesg,data,"Error in f-score calculation")
logging.exception("Error in f-score calculation")
log_tuple =[
"Error in f-score calculation",
datetime.now().strftime('%H:%M:%S'),
"ERROR"
]
add_log_entry(data,log_tuple)
mesg.save(update_fields=['status','code'])
raise e

try:
mesg.result_count = len(new_res)
mesg.result_stat = ScoreStatCalc(new_res)
except Exception as e:
logging.exception("Error in ScoreStatCalculation or result count")
post_processing_error(mesg,data,"Error in score stat calculation")
raise e
log_tuple =[
"Error in score stat calculation",
datetime.now().strftime('%H:%M:%S'),
"DEBUG"
]
add_log_entry(data,log_tuple)
mesg.status ='E'
mesg.code=400
mesg.save(update_fields=['status','code'])
try:
mesg.status='D'
mesg.code=200
mesg.status=status
mesg.code=code
mesg.save_compressed_dict(data)
logging.info("Time before save")
with transaction.atomic():
Expand Down Expand Up @@ -693,12 +734,12 @@ def merge_and_post_process(parent_pk,message_to_merge, agent_name, counter=0):
logging.info('post processing complete for agent %s with pk %s is returned & ready to be preprocessed' % (agent_name, str(merged.id)))

except Exception as e:
logging.info("Problem with post processing for agent %s pk: %s " % (agent_name, (parent_pk)))
logging.info(e, exc_info=True)
logging.info('error message %s' % str(e))
merged.status='E'
merged.code = 422
merged.save()
logging.exception("Problem with one/more post processing steps for agent %s pk: %s " % (agent_name, (parent_pk)))
# logging.info(e, exc_info=True)
# logging.info('error message %s' % str(e))
# merged.status='E'
# merged.code = 422
# merged.save()

def remove_blocked(mesg, data, blocklist=None):
try:
Expand Down Expand Up @@ -947,10 +988,7 @@ def appraise(mesg,data, agent_name,retry_counter=0):
logging.error("3 consecutive Errors from appraise for agent %s and pk %s " % (agent_name,str(mesg.id)))
raise Exception
except Exception as e:

logging.error("Problem with appraiser for agent %s and pk %s " % (agent_name,str(mesg.id)))
logging.error(type(e).__name__)
logging.error(e.args)
logging.error("Problem with appraiser for agent %s and pk %s of type %s" % (agent_name,str(mesg.id),type(e).__name__))
logging.error("Adding default ordering_components for agent %s and pk %s " % (agent_name,str(mesg.id)))
raise e

Expand Down Expand Up @@ -1002,15 +1040,8 @@ def annotate_nodes(mesg,data,agent_name):
else:
post_processing_error(mesg,data,"Error in annotation of nodes")
except Exception as e:
logging.info('node annotation internal error msg is for agent %s with pk: %s is %s' % (agent_name,str(mesg.pk),str(e)))
logging.exception("error in node annotation internal function")

logging.exception('node annotation internal error msg is for agent %s with pk: %s is %s' % (agent_name,str(mesg.pk),str(e)))
raise e
#else:
# with open(str(mesg.actor)+".json", "w") as outfile:
# outfile.write(json_data)
# post_processing_error(mesg,data,"Error in annotation of nodes")


def normalize_scores(data,key, agent_name):
res=get_safe(data,"message","results")
Expand Down Expand Up @@ -1080,7 +1111,7 @@ def post_processing_error(mesg,data,text):
mesg.code = 206
log_tuple=[text,
(mesg.updated_at).strftime('%H:%M:%S'),
"WARNING"]
"DEBUG"]
logging.info(f'the log_tuple is %s'% log_tuple)
add_log_entry(data,log_tuple)

Expand Down