Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make compatibility with the limited DataCite EZID implementation #15

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jusana
Copy link

@jusana jusana commented Mar 1, 2021

@mbjones
Copy link
Member

mbjones commented Mar 2, 2021

@jusana we still need to test against the DataCite test server. My attempt to get an account there failed, and I lost track of the task in the throng of competing TODOs. Can you describe how this has been tested, and how we can be sure both the new DataCite APIs and the old APIs at EZID continue to work properly?

@yvanlebras
Copy link

Thank you @mbjones for coming back to us. Last year we (french biodiversity e-infrastructure, PNDB) used a test account created by the French Datacite node, represented by INIST unit. Now we have a production account (so are ready to add doi to our metacat documents ! ) But no more test account. I think you need to ask a test account [here]("Testing Guide" https://support.datacite.org/docs/testing-guide) so you can test Julien code. Whishing you a good week. Best, Yvan

@jusana
Copy link
Author

jusana commented Mar 2, 2021

Hi @mbjones ,

Well ..... as you can see i just forced the basicauth header in the client and changed the new line separator ....
Regarding the tests, there is something really weird since the mock tests dont seem to match the real usage of the lib in metacat itself ... So if you use a datacite account the tests will fail (for instance since there is non "login" route in datacite ezid implementation) .... but it is actually working when added to the metacat libs !
i tested it in my preproduction environment (with datacite sandbox)
image
image
And if i use the default EZID account (apitest/apitest shoulder doi:10.5072/FK2) the tests still succeed with my changes in the code !!

But anyways, it seems Datacite is dropping EZID support by end of the year !! So I guess, having a proper dataCite API client is the only way for long term !!
image

But, actually GBIF has a dataCite API REST java client !!!! (https://github.com/gbif/datacite-rest-client)
I can talk with my colleague here in MNHN in charge dedicated GBIF developments to learn more about this client if you want !

Happy to give you more infos about that !

julien.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants