[PI-528] collapse versions and deactivate etl tests #409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -7,6 +7,16 @@ | |||
| from pydantic import validator | |||
|
|
|||
|
|
|||
| def validate_key(key: str, type: "DeviceKeyType"): | |||
There was a problem hiding this comment.
This function exists twice in this file, on line 59
| ) | ||
|
|
||
| yield new_device | ||
| # from dataclasses import astuple |
There was a problem hiding this comment.
ah this file is getting deleted soon and is getting used anywhere but could be useful for reference when rewriting the changelog
jaklinger
force-pushed
the
feature/PI-528-reset_versions_to_v1
branch
from
26f3964
to
f2241c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.