Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ln_closea in NEMO >=4.2 #149

Open
jdha opened this issue Jan 2, 2024 · 2 comments · Fixed by #154
Open

ln_closea in NEMO >=4.2 #149

jdha opened this issue Jan 2, 2024 · 2 comments · Fixed by #154
Assignees
@jdha
Labels
task workflow

Comments

@jdha
Copy link
Contributor

jdha commented Jan 2, 2024

The way ln_closea is defined in the NEMO >=4.2 has changed. The namelist_cfg_template needs to be updated to reflect this. Also the closed seas masks in the domain_cfg.nc will need to be redefined.
@jdha jdha added the bug Something isn't working label Jan 2, 2024
@jdha jdha self-assigned this Jan 2, 2024
jdha added a commit that referenced this issue Jan 15, 2024
@jdha
Adding a temporary fix for closed seas (see #149)
8062a1e
@jdha jdha mentioned this issue Jan 15, 2024
Merged
@jdha jdha linked a pull request Jan 15, 2024 that will close this issue
Adding a temporary fix for closed seas (see #149) #154
Merged
jdha added a commit that referenced this issue Jan 15, 2024
@jdha
updating namelist_cfg_template for closed seas (see #149)
8e0b71f
@jdha jdha added task workflow and removed bug Something isn't working labels Jan 15, 2024
@jdha
Copy link
Contributor Author

jdha commented Jan 15, 2024

Quick fix for the time being (until domain_cfg is updated):

104,105c104
<       !CALL read_csmask( cn_domcfg, 'mask_opensea' , mask_opnsea  )
<       CALL read_csmask( cn_domcfg, 'closea_mask' , mask_opnsea  ) ! JDHA quick fix to use 4.0.4 closea_mask
---
>       CALL read_csmask( cn_domcfg, 'mask_opensea' , mask_opnsea  )
114,118d112
<          ! JDHA quick fix to use 4.0.4 closea_mask
<          WHERE( mask_opnsea(:,:) /= 0 )
<             mask_opnsea(:,:) = -1
<          END WHERE
<          mask_opnsea(:,:) = mask_opnsea(:,:) + 1

jasontempestholt added a commit that referenced this issue Jan 25, 2024
@jasontempestholt
Merge pull request #154 from NOC-MSM/149-closea-namelist-update
a03c627 
Adding a temporary fix for closed seas (see #149)
@jdha jdha reopened this Jan 27, 2024
@jdha
Copy link
Contributor Author

jdha commented Jan 27, 2024

Keeping this open as PR was only a temporary work around to get 4.2.2 simulations up and running

@github-project-automation github-project-automation bot moved this to In progress in SE-NEMO Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jdha jdha

Labels
task workflow
Projects
SE-NEMO
Status: In progress
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adding a temporary fix for closed seas (see #149) NOC-MSM/SE-NEMO
1 participant
@jdha