Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add endpoint for cloud backup file deletion #745

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add endpoint for cloud backup file deletion #745

wants to merge 1 commit into from
+96 −4

Conversation

klejejs
Copy link
Contributor

@klejejs klejejs commented Nov 21, 2024

SSIA.

klejejs
klejejs commented Nov 21, 2024
View reviewed changes
hass_nabucasa/cloud_api.py
@@ -49,7 +50,7 @@ class FilesHandlerListEntry(TypedDict):
Key: str
Size: int
LastModified: str
Metadata: dict[str, str]
Metadata: dict[str, Any]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is more appropriate as metadata can be a JSON of any value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartinHjelmare MartinHjelmare MartinHjelmare approved these changes

@bemble bemble Awaiting requested review from bemble

@ludeeus ludeeus Awaiting requested review from ludeeus

@edenhaus edenhaus Awaiting requested review from edenhaus

@victorigualada victorigualada Awaiting requested review from victorigualada

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@klejejs @MartinHjelmare