Wrap channel in an asyncio.Transport to eliminate loop back connection PoC #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdraco
changed the title
bdraco
commented
Oct 24, 2024
| try: | ||
| from_peer = await self._channel.read() | ||
| except MultiplexerTransportClose: | ||
| raise |
There was a problem hiding this comment.
Pretty sure connect lost will always get called because close on the finally block where this task is awaited but it should get a test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The concept is that the
SelectorTransportis replaced with the newChannelTransportthat is a wrapper around the channel so we don't need to connect back to localhost since we can create the request handler, connect up the transport and protocol andstart_tls. It could be a bit more efficient if the channel became anasyncio.Transportbut its already more efficient anyways because it eliminated the loopback connection so one less copy.Also since aiohttp gets the ip address from the transport it can be set to whatever is desired