Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made delete_fsxn_svm smarter #194

Merged
merged 11 commits into from
Oct 5, 2024
Merged

Made delete_fsxn_svm smarter #194

merged 11 commits into from
Oct 5, 2024

Conversation

kcantrel
Copy link
Collaborator

@kcantrel kcantrel commented Oct 2, 2024

Made all the create and delete script support a 'wait' option; Made the delete_fsxn_svm support deleting all the volumes under the SVM; Now delete_fsxn_filesystem calls delete_fsxn_svm to delete SVMs, and delete_fsxn_svm calls delete_fsxn_volume to delete volumes.

…he delete_fsxn_svm support deleting all the volumes under the SVM; Now delete_fsxn_filesystem calls delete_fsxn_svm to delete SVMs, and delete_fsxn_svm calls delete_fsxn_volume to delete volumes.
@nichollri nichollri self-assigned this Oct 3, 2024
Copy link
Collaborator

@nichollri nichollri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason why on fsxn-create you made the option --wait, but on svm create you made it just -w?

@kcantrel
Copy link
Collaborator Author

kcantrel commented Oct 4, 2024

Is there a reason why on fsxn-create you made the option --wait, but on svm create you made it just -w?

Since creating a file system requires a lot of options, I had to go with the double dash "long name" method of passing options, whereas with creating a SVM it only requires two, and only accepts 5 options. I didn't want to change all the other scripts to conform to what I had to do with create_fsxn_filesystem.

I could have made the -w option consistent among all the scripts. but I decided to make all the options for the create_fsxn_filesystem script require the double dash method so it would have a consistent semantics. I did make one exception in that it recognizes -h to display help. Having said that, it, of course it wouldn't take much to add -w as another way to specify the wait option if you really think it is needed.

Copy link
Collaborator

@nichollri nichollri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is fine. Let's just get this merged in.

Copy link
Collaborator

@nichollri nichollri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested out latest changes for error messages and they displayed correctly when I had snapmirrors and vserver peers on cleanup.

@kcantrel kcantrel merged commit 30c9fe3 into main Oct 5, 2024
9 checks passed
@kcantrel kcantrel deleted the make_delete_fsxn_svm_smarter branch October 5, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants