Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Removing legacy modules. Disabled SSE/WS client tests for now #1995

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

paulbakker
Copy link
Collaborator

Preview branch removing all legacy modules. This will be merged in late 2024. From then on, the DGS/Spring GraphQL integration will be the only implementation.

@paulbakker
Copy link
Collaborator Author

@srinivasankavitha @kilink Preparing this branch for onboarding purposes. Not ready to merge yet, but it's a preview of things to come.
Note that I've disabled some client SSE/WS tests for now, need to replace some things in the setup with Spring GraphQL to get those to work.

@srinivasankavitha
Copy link
Contributor

Looks good to me. I've noticed quite a few projects that add graphql-dgs-spring-boot-starter as a dependency in their build.gradle files in addition to the starter. This is incorrect usage in any case. Calling it out explicitly so we are not surprised by breakages there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants