Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed unused dependencies using nebula-linter #370

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Removed unused dependencies using nebula-linter #370

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion mantis-client/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ dependencies {
implementation libraries.slf4jApi
implementation libraries.spectatorApi
testImplementation libraries.junit4
testImplementation libraries.mockitoCore
}

task runsubmit(type: JavaExec) {
Expand Down
4 changes: 1 addition & 3 deletions mantis-common/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ dependencies {
api project(":mantis-common-serde")
api "io.netty:netty-codec-http:$nettyVersion"
api "io.netty:netty-buffer:$nettyVersion"
api group: 'io.netty', name: 'netty-transport-native-epoll', classifier: 'linux-x86_64', version: nettyVersion
api "org.xerial.snappy:snappy-java:$snappyVersion"
api "org.jctools:jctools-core:$jctoolsVersion"

Expand All @@ -41,9 +40,8 @@ dependencies {
implementation libraries.commonsIo
implementation 'net.jcip:jcip-annotations:1.0'

testImplementation libraries.spectatorApi
implementation 'com.netflix.spectator:spectator-api:1.3.+'
Comment on lines -44 to +43
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Andyz26 I'm guessing this config change is not doable? Can you take a look?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it's a good idea to include actual spectator lib in the common module.

testImplementation libraries.commonsLang3
testImplementation "org.hamcrest:hamcrest-core:1.3"
testImplementation libraries.junit4
testImplementation libraries.mockitoCore
}
7 changes: 0 additions & 7 deletions mantis-connectors/mantis-connector-iceberg/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,21 +46,14 @@ dependencies {
// Exclude in case there are differences in SHAs between 0.7.0 incubation versions.
shadow "org.apache.iceberg:iceberg-api:$icebergVersion"
shadow "org.apache.iceberg:iceberg-core:$icebergVersion"
shadow "org.apache.iceberg:iceberg-data:$icebergVersion"
shadow "org.apache.iceberg:iceberg-parquet:$icebergVersion"
shadow "org.apache.avro:avro:$avroVersion"
shadow "org.apache.parquet:parquet-hadoop:${parquetVersion}"

// We only need this for local mains(). Users bring their own implementation.
shadow libraries.slf4jLog4j12

testImplementation project(":mantis-runtime").sourceSets.test.output
testImplementation "org.apache.hadoop:hadoop-common:$hadoopVersion"
testImplementation "org.apache.iceberg:iceberg-data:$icebergVersion"
testImplementation libraries.junitJupiter
testImplementation libraries.mockitoCore
testImplementation libraries.spectatorApi
testImplementation libraries.slf4jLog4j12
}

tasks.jar.dependsOn tasks.shadowJar
Expand Down
4 changes: 0 additions & 4 deletions mantis-connectors/mantis-connector-kafka/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,12 +30,8 @@ dependencies {

api libraries.rxJava
api "com.netflix.spectator:spectator-api:$spectatorVersion"
api "com.netflix.archaius:archaius2-api:$archaiusVersion"
api "com.netflix.archaius:archaius2-core:$archaiusVersion"

testImplementation libraries.junit4
testImplementation project(':mantis-runtime').sourceSets.test.output
testImplementation libraries.mockitoAll
testImplementation "com.github.tomakehurst:wiremock-jre8:2.21.0"
testCompileOnly "com.netflix.archaius:archaius2-core:$archaiusVersion"
}
1 change: 0 additions & 1 deletion mantis-control-plane/mantis-control-plane-client/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,5 @@ dependencies {

testImplementation libraries.junit4
testImplementation libraries.mockitoAll
testImplementation libraries.spectatorApi
testImplementation(testFixtures(project(":mantis-common")))
}
1 change: 0 additions & 1 deletion mantis-control-plane/mantis-control-plane-core/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,6 @@ dependencies {

testFixturesImplementation libraries.flinkRpcImpl
testImplementation libraries.junit4
testImplementation libraries.mockitoAll
}

// This task makes flink-rpc-akka.jar available in mantis-control-plane-core classpath,
Expand Down
2 changes: 0 additions & 2 deletions mantis-examples/mantis-examples-core/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,4 @@ apply plugin: 'java-library'
dependencies {
implementation project(':mantis-runtime')

implementation libraries.slf4jApi
implementation libraries.slf4jLog4j12
}
2 changes: 0 additions & 2 deletions mantis-examples/mantis-examples-groupby-sample/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,7 @@ task execute(type: JavaExec) {

dependencies {
implementation project(':mantis-runtime')
implementation "com.netflix.spectator:spectator-api:1.3.+"

implementation libraries.mockneat
implementation libraries.slf4jApi
implementation libraries.slf4jLog4j12
}
1 change: 0 additions & 1 deletion mantis-examples/mantis-examples-jobconnector-sample/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,5 +23,4 @@ dependencies {
implementation "io.mantisrx:mantis-connector-job:$mantisConnectorsVersion"

implementation libraries.slf4jApi
implementation libraries.slf4jLog4j12
}
3 changes: 0 additions & 3 deletions mantis-examples/mantis-examples-mantis-publish-sample/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,12 +57,9 @@ dependencies {
implementation project(":mantis-publish:mantis-publish-netty-guice")

implementation libraries.rxJava
implementation "com.netflix.spectator:spectator-ext-ipc:$spectatorVersion"
implementation "com.netflix.archaius:archaius2-core:$archaiusVersion"
implementation "com.netflix.archaius:archaius2-guice:$archaiusVersion"
implementation "com.google.inject:guice:$guiceVersion"
implementation "com.netflix.spectator:spectator-nflx-plugin:$spectatorVersion"
implementation libraries.mockneat

implementation libraries.slf4jLog4j12
}
1 change: 0 additions & 1 deletion mantis-examples/mantis-examples-sine-function/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,5 +27,4 @@ task execute(type:JavaExec) {
}
dependencies {
implementation project(':mantis-runtime')
implementation "com.netflix.spectator:spectator-api:1.3.+"
}
2 changes: 0 additions & 2 deletions mantis-examples/mantis-examples-synthetic-sourcejob/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,5 @@ dependencies {

implementation libraries.mockneat
implementation libraries.slf4jApi
implementation libraries.slf4jLog4j12

testImplementation "org.mockito:mockito-all:1.9.5"
}
2 changes: 0 additions & 2 deletions mantis-examples/mantis-examples-twitter-sample/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,7 @@ task execute(type: JavaExec) {

dependencies {
implementation project(':mantis-runtime')
implementation "com.netflix.spectator:spectator-api:1.3.+"
implementation 'com.twitter:hbc-core:2.2.0'

implementation libraries.slf4jApi
implementation libraries.slf4jLog4j12
}
3 changes: 0 additions & 3 deletions mantis-examples/mantis-examples-wordcount/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,6 @@ task execute(type: JavaExec) {
dependencies {
implementation project(':mantis-runtime')
implementation project(':mantis-examples:mantis-examples-core')
implementation "com.netflix.spectator:spectator-api:1.3.+"
implementation 'com.twitter:hbc-core:2.2.0'

implementation libraries.slf4jApi
implementation libraries.slf4jLog4j12
}
4 changes: 1 addition & 3 deletions mantis-network/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,11 +24,9 @@ dependencies {
implementation "io.mantisrx:mql-jvm:$mqlVersion"
api project(':mantis-common')
compileOnly libraries.spectatorApi
testImplementation libraries.spectatorApi
implementation 'com.netflix.spectator:spectator-api:1.3.+'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above. Not sure if this change is doable.


testImplementation libraries.junitJupiter
testImplementation libraries.mockitoCore
testImplementation libraries.slf4jLog4j12
}

test {
Expand Down
1 change: 0 additions & 1 deletion mantis-publish/mantis-publish-core/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@ dependencies {

testImplementation libraries.junitJupiter
testImplementation libraries.mockitoCore
testImplementation libraries.slf4jLog4j12
testImplementation libraries.commonsIo
}

Expand Down
3 changes: 0 additions & 3 deletions mantis-publish/mantis-publish-netty-guice/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,11 +29,8 @@ dependencies {
implementation "com.google.inject:guice:$guiceVersion"
implementation "com.netflix.spectator:spectator-nflx-plugin:$spectatorVersion"

implementation libraries.slf4jApi

testImplementation libraries.junitJupiter
testImplementation libraries.mockitoCore
testImplementation libraries.slf4jLog4j12
}

test {
Expand Down
1 change: 0 additions & 1 deletion mantis-publish/mantis-publish-netty/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ dependencies {

testImplementation libraries.junitJupiter
testImplementation libraries.mockitoCore
testImplementation libraries.slf4jLog4j12
}

test {
Expand Down
1 change: 0 additions & 1 deletion mantis-runtime-loader/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ dependencies {
api project(":mantis-control-plane:mantis-control-plane-client")

testImplementation libraries.junit4
testImplementation libraries.mockitoAll
testImplementation(testFixtures(project(":mantis-common")))

}
2 changes: 1 addition & 1 deletion mantis-runtime/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ dependencies {
api project(':mantis-common')
api libraries.slf4jApi
compileOnly libraries.spectatorApi
testImplementation libraries.spectatorApi
implementation 'com.netflix.spectator:spectator-api:1.3.+'
testImplementation libraries.junit4
testImplementation libraries.mockitoCore

Expand Down
1 change: 0 additions & 1 deletion mantis-server/mantis-server-agent/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ dependencies {
implementation libraries.hadoopCommon
implementation libraries.spotifyFutures
implementation libraries.slf4jApi
implementation libraries.slf4jLog4j12

testImplementation libraries.junit4
testImplementation libraries.mockitoAll
Expand Down
1 change: 0 additions & 1 deletion mantis-server/mantis-server-worker-client/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,5 +21,4 @@ dependencies {
testImplementation libraries.junit4
testImplementation libraries.mockitoAll
testImplementation libraries.spectatorApi
testImplementation 'org.hamcrest:hamcrest-all:1.3'
}
4 changes: 0 additions & 4 deletions mantis-server/mantis-server-worker/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,22 +31,18 @@ dependencies {

implementation "org.apache.mesos:mesos:$mesosVersion"
implementation libraries.slf4jApi
implementation libraries.slf4jLog4j12
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice change.

implementation libraries.vavr
implementation('nz.ac.waikato.cms.moa:moa:2017.06') {
exclude group: 'com.github.spullara.cli-parser', module: 'cli-parser'
exclude group: 'org.pentaho.pentaho-commons', module: 'pentaho-package-manager'
}
implementation "org.apache.httpcomponents:httpclient:$httpComponentsVersion"
implementation "io.mantisrx:mantis-rxcontrol:$mantisRxControlVersion"
implementation "com.yahoo.datasketches:sketches-core:0.9.1"

implementation libraries.spectatorApi

testImplementation libraries.junit4
testImplementation libraries.mockitoAll
testImplementation 'org.hamcrest:hamcrest-all:1.3'
testImplementation libraries.vavrTest
testImplementation(testFixtures(project(":mantis-common")))
testImplementation(testFixtures(project(":mantis-control-plane:mantis-control-plane-core")))
}
Expand Down
1 change: 0 additions & 1 deletion mantis-shaded/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,6 @@ dependencies {
shaded "jline:jline:$jlineVersion"
shaded "io.netty:netty:$nettyVersion"

implementation libraries.vavr
}

shadowJar {
Expand Down
1 change: 0 additions & 1 deletion mantis-source-jobs/mantis-source-job-publish/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ dependencies {
implementation libraries.slf4jApi

testImplementation libraries.junitJupiter
testImplementation libraries.mockitoCore
}

test {
Expand Down