Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NeuroNexusRawIO: fix the get_signal_size #1576

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

zm711
Copy link
Contributor

@zm711 zm711 commented Sep 30, 2024

@alejoe91, if you have a moment this is a quick review.

Discovered here: https://github.com/SpikeInterface/spikeinterface/actions/runs/11106106976/job/30853717171?pr=3235

Should be shape[0] instead of size which is (shape[0] x shape[1]).

@zm711 zm711 requested a review from alejoe91 September 30, 2024 12:49
@alejoe91 alejoe91 merged commit da0f09c into NeuralEnsemble:master Sep 30, 2024
3 checks passed
@zm711 zm711 deleted the neuronexus-patch branch September 30, 2024 15:10
@zm711 zm711 added this to the 0.14.0 milestone Oct 1, 2024
@zm711 zm711 modified the milestones: 0.14.0, 0.13.4 Oct 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants