Shared - Audio Language Fixes

Fixes #897
NickvisionApps · Oct 15, 2024 · d30ee03 · d30ee03
1 parent a5ed80d
commit d30ee03
Show file tree

Hide file tree

Showing 39 changed files with 306 additions and 452 deletions.
diff --git a/libparabolic/src/controllers/adddownloaddialogcontroller.cpp b/libparabolic/src/controllers/adddownloaddialogcontroller.cpp
@@ -157,6 +157,7 @@ namespace Nickvision::TubeConverter::Shared::Controllers
         {
             return languages;
         }
+        languages.push_back(_("Default"));
         if(!m_urlInfo->isPlaylist())
         {
             const Media& media{ m_urlInfo->get(0) };
@@ -181,7 +182,6 @@ namespace Nickvision::TubeConverter::Shared::Controllers
                 }
             }
         }
-        languages.insert(languages.begin(), _("Default"));
         return languages;
     }
 

diff --git a/libparabolic/src/controllers/mainwindowcontroller.cpp b/libparabolic/src/controllers/mainwindowcontroller.cpp
@@ -41,7 +41,7 @@ namespace Nickvision::TubeConverter::Shared::Controllers
         m_appInfo.setVersion({ "2024.10.2-next" });
         m_appInfo.setShortName(_("Parabolic"));
         m_appInfo.setDescription(_("Download web video and audio"));
-        m_appInfo.setChangelog("- The user's preferred video codec will now be used in playlist downloads where individual quality/format selection is not available\n- Partially downloaded media will now correctly resume when retrying the failed download instead of restarting the download from scratch\n- Fixed an issue where some websites failed in a 403 forbidden error");
+        m_appInfo.setChangelog("- The user's preferred video codec will now be used in playlist downloads where individual quality/format selection is not available\n- Partially downloaded media will now correctly resume when retrying the failed download instead of restarting the download from scratch\n- Fixed an issue where some websites failed in a 403 forbidden error\n- Fixed an issue where some videos would download as audio only after selecting an audio language\n- Fixed an issue where the incorrect audio language was downloaded");
         m_appInfo.setSourceRepo("https://github.com/NickvisionApps/Parabolic");
         m_appInfo.setIssueTracker("https://github.com/NickvisionApps/Parabolic/issues/new");
         m_appInfo.setSupportUrl("https://github.com/NickvisionApps/Parabolic/discussions");

diff --git a/libparabolic/src/models/downloadoptions.cpp b/libparabolic/src/models/downloadoptions.cpp
@@ -322,7 +322,14 @@ namespace Nickvision::TubeConverter::Shared::Models
         else if(m_audioFormat)
         {
             arguments.push_back("--format");
-            arguments.push_back(m_audioFormat->getId());
+            if(m_fileType.isVideo())
+            {
+                arguments.push_back("bv+" + m_audioFormat->getId());
+            }
+            else
+            {
+                arguments.push_back(m_audioFormat->getId());
+            }
         }
         if(!std::filesystem::exists(m_saveFolder))
         {

diff --git a/resources/linux/org.nickvision.tubeconverter.metainfo.xml.in b/resources/linux/org.nickvision.tubeconverter.metainfo.xml.in
@@ -60,6 +60,8 @@
         <p>- The user's preferred video codec will now be used in playlist downloads where individual quality/format selection is not available</p>
         <p>- Partially downloaded media will now correctly resume when retrying the failed download instead of restarting the download from scratch</p>
         <p>- Fixed an issue where some websites failed in a 403 forbidden error</p>
+        <p>- Fixed an issue where some videos would download as audio only after selecting an audio language</p>
+        <p>- Fixed an issue where the incorrect audio language was downloaded</p>
       </description>
     </release>
   </releases>

diff --git a/resources/po/ady.po b/resources/po/ady.po
@@ -7,7 +7,7 @@ msgid ""
 msgstr ""
 "Project-Id-Version: PACKAGE VERSION\n"
 "Report-Msgid-Bugs-To: \n"
-"POT-Creation-Date: 2024-10-13 13:34-0400\n"
+"POT-Creation-Date: 2024-10-15 10:47-0400\n"
 "PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
 "Last-Translator: Automatically generated\n"
 "Language-Team: none\n"
@@ -73,12 +73,12 @@ msgstr ""
 msgid "Best"
 msgstr ""
 
-#: libparabolic/src/controllers/adddownloaddialogcontroller.cpp:170
-msgid "Audio Description"
+#: libparabolic/src/controllers/adddownloaddialogcontroller.cpp:160
+msgid "Default"
 msgstr ""
 
-#: libparabolic/src/controllers/adddownloaddialogcontroller.cpp:184
-msgid "Default"
+#: libparabolic/src/controllers/adddownloaddialogcontroller.cpp:171
+msgid "Audio Description"
 msgstr ""
 
 #: libparabolic/src/controllers/mainwindowcontroller.cpp:42
@@ -126,22 +126,18 @@ msgid "Unable to download and install update"
 msgstr ""
 
 #: libparabolic/src/events/downloadprogresschangedeventargs.cpp:21
-#, c++-format
 msgid "{:.2f} GiB/s"
 msgstr ""
 
 #: libparabolic/src/events/downloadprogresschangedeventargs.cpp:25
-#, c++-format
 msgid "{:.2f} MiB/s"
 msgstr ""
 
 #: libparabolic/src/events/downloadprogresschangedeventargs.cpp:29
-#, c++-format
 msgid "{:.2f} KiB/s"
 msgstr ""
 
 #: libparabolic/src/events/downloadprogresschangedeventargs.cpp:33
-#, c++-format
 msgid "{:.2f} B/s"
 msgstr ""
 
@@ -916,7 +912,6 @@ msgid "No Subtitles Available"
 msgstr ""
 
 #: org.nickvision.tubeconverter.gnome/src/views/adddownloaddialog.cpp:173
-#, c++-format
 msgid "{} items"
 msgstr ""
 
@@ -1028,7 +1023,6 @@ msgid "Changelog:"
 msgstr ""
 
 #: org.nickvision.tubeconverter.qt/src/controls/aboutdialog.cpp:39
-#, c++-format
 msgid ""
 "Developers:\n"
 "{}\n"
@@ -1096,7 +1090,6 @@ msgid ""
 msgstr ""
 
 #: org.nickvision.tubeconverter.qt/src/views/adddownloaddialog.cpp:206
-#, c++-format
 msgid "Items ({})"
 msgstr ""
 

diff --git a/resources/po/ar.po b/resources/po/ar.po
@@ -7,7 +7,7 @@ msgid ""
 msgstr ""
 "Project-Id-Version: PACKAGE VERSION\n"
 "Report-Msgid-Bugs-To: \n"
-"POT-Creation-Date: 2024-10-13 13:34-0400\n"
+"POT-Creation-Date: 2024-10-15 10:47-0400\n"
 "PO-Revision-Date: 2024-09-11 13:02+0000\n"
 "Last-Translator: Deflector <[email protected]>\n"
 "Language-Team: Arabic <https://hosted.weblate.org/projects/nickvision-tube-"
@@ -76,14 +76,14 @@ msgstr "صوت (بصيغة WAV)"
 msgid "Best"
 msgstr "الأفضل"
 
-#: libparabolic/src/controllers/adddownloaddialogcontroller.cpp:170
-msgid "Audio Description"
-msgstr ""
-
-#: libparabolic/src/controllers/adddownloaddialogcontroller.cpp:184
+#: libparabolic/src/controllers/adddownloaddialogcontroller.cpp:160
 msgid "Default"
 msgstr "جودة افتراضية"
 
+#: libparabolic/src/controllers/adddownloaddialogcontroller.cpp:171
+msgid "Audio Description"
+msgstr ""
+
 #: libparabolic/src/controllers/mainwindowcontroller.cpp:42
 #: org.nickvision.tubeconverter.qt/src/views/mainwindow.cpp:39
 msgid "Parabolic"
@@ -134,22 +134,20 @@ msgid "Unable to download and install update"
 msgstr "لا يمكن تحميل وتنزيل التحديث"
 
 #: libparabolic/src/events/downloadprogresschangedeventargs.cpp:21
-#, c++-format
 msgid "{:.2f} GiB/s"
 msgstr "{:.2f} جيجابايت/ث"
 
 #: libparabolic/src/events/downloadprogresschangedeventargs.cpp:25
-#, fuzzy, c++-format
+#, fuzzy
 msgid "{:.2f} MiB/s"
 msgstr "{0:f1} ميجابايت\\ث"
 
 #: libparabolic/src/events/downloadprogresschangedeventargs.cpp:29
-#, fuzzy, c++-format
+#, fuzzy
 msgid "{:.2f} KiB/s"
 msgstr "{0:f1} كيلوبايت\\ث"
 
 #: libparabolic/src/events/downloadprogresschangedeventargs.cpp:33
-#, c++-format
 msgid "{:.2f} B/s"
 msgstr "{:.2f} بايت/ث"
 
@@ -936,7 +934,6 @@ msgid "No Subtitles Available"
 msgstr "لديك تحديث جديد"
 
 #: org.nickvision.tubeconverter.gnome/src/views/adddownloaddialog.cpp:173
-#, c++-format
 msgid "{} items"
 msgstr "{} عنصر/عناصر"
 
@@ -1048,7 +1045,6 @@ msgid "Changelog:"
 msgstr "تغييرات التحديث:"
 
 #: org.nickvision.tubeconverter.qt/src/controls/aboutdialog.cpp:39
-#, c++-format
 msgid ""
 "Developers:\n"
 "{}\n"
@@ -1127,7 +1123,7 @@ msgstr ""
 "المستخدم، والمتصفح المستخدم لبيانات تعريف الإرتباط في الإعدادات."
 
 #: org.nickvision.tubeconverter.qt/src/views/adddownloaddialog.cpp:206
-#, fuzzy, c++-format
+#, fuzzy
 msgid "Items ({})"
 msgstr "وسائط قائمة التشغيل ({})"
 

diff --git a/resources/po/bg.po b/resources/po/bg.po
@@ -7,7 +7,7 @@ msgid ""
 msgstr ""
 "Project-Id-Version: PACKAGE VERSION\n"
 "Report-Msgid-Bugs-To: \n"
-"POT-Creation-Date: 2024-10-13 13:34-0400\n"
+"POT-Creation-Date: 2024-10-15 10:47-0400\n"
 "PO-Revision-Date: 2024-04-08 20:37+0000\n"
 "Last-Translator: twlvnn <[email protected]>\n"
 "Language-Team: Bulgarian <https://hosted.weblate.org/projects/nickvision-"
@@ -82,12 +82,12 @@ msgstr "Песен"
 msgid "Best"
 msgstr "Най-добро"
 
-#: libparabolic/src/controllers/adddownloaddialogcontroller.cpp:170
-msgid "Audio Description"
+#: libparabolic/src/controllers/adddownloaddialogcontroller.cpp:160
+msgid "Default"
 msgstr ""
 
-#: libparabolic/src/controllers/adddownloaddialogcontroller.cpp:184
-msgid "Default"
+#: libparabolic/src/controllers/adddownloaddialogcontroller.cpp:171
+msgid "Audio Description"
 msgstr ""
 
 #: libparabolic/src/controllers/mainwindowcontroller.cpp:42
@@ -141,22 +141,22 @@ msgid "Unable to download and install update"
 msgstr "Неуспешно изтегляне и инсталиране на обновленията."
 
 #: libparabolic/src/events/downloadprogresschangedeventargs.cpp:21
-#, fuzzy, c++-format
+#, fuzzy
 msgid "{:.2f} GiB/s"
 msgstr "{0:f1} ГБ/с"
 
 #: libparabolic/src/events/downloadprogresschangedeventargs.cpp:25
-#, fuzzy, c++-format
+#, fuzzy
 msgid "{:.2f} MiB/s"
 msgstr "{0:f1} МБ/с"
 
 #: libparabolic/src/events/downloadprogresschangedeventargs.cpp:29
-#, fuzzy, c++-format
+#, fuzzy
 msgid "{:.2f} KiB/s"
 msgstr "{0:f1} КБ/с"
 
 #: libparabolic/src/events/downloadprogresschangedeventargs.cpp:33
-#, fuzzy, c++-format
+#, fuzzy
 msgid "{:.2f} B/s"
 msgstr "{0:f1} Б/с"
 
@@ -976,7 +976,7 @@ msgid "No Subtitles Available"
 msgstr "Налично е ново обновление."
 
 #: org.nickvision.tubeconverter.gnome/src/views/adddownloaddialog.cpp:173
-#, fuzzy, c++-format
+#, fuzzy
 msgid "{} items"
 msgstr "{0} от {1} елемент"
 
@@ -1093,7 +1093,7 @@ msgid "Changelog:"
 msgstr "Дневник на промените"
 
 #: org.nickvision.tubeconverter.qt/src/controls/aboutdialog.cpp:39
-#, fuzzy, c++-format
+#, fuzzy
 msgid ""
 "Developers:\n"
 "{}\n"
@@ -1181,7 +1181,7 @@ msgid ""
 msgstr ""
 
 #: org.nickvision.tubeconverter.qt/src/views/adddownloaddialog.cpp:206
-#, fuzzy, c++-format
+#, fuzzy
 msgid "Items ({})"
 msgstr "{0} от {1} елемент"
 

diff --git a/resources/po/bn.po b/resources/po/bn.po
@@ -7,7 +7,7 @@ msgid ""
 msgstr ""
 "Project-Id-Version: PACKAGE VERSION\n"
 "Report-Msgid-Bugs-To: \n"
-"POT-Creation-Date: 2024-10-13 13:34-0400\n"
+"POT-Creation-Date: 2024-10-15 10:47-0400\n"
 "PO-Revision-Date: 2023-10-02 18:59+0000\n"
 "Last-Translator: Soumyadeep Ghosh <[email protected]>\n"
 "Language-Team: Bengali <https://hosted.weblate.org/projects/nickvision-tube-"
@@ -82,14 +82,14 @@ msgstr "গান"
 msgid "Best"
 msgstr "সর্বোত্তম"
 
-#: libparabolic/src/controllers/adddownloaddialogcontroller.cpp:170
-msgid "Audio Description"
-msgstr ""
-
-#: libparabolic/src/controllers/adddownloaddialogcontroller.cpp:184
+#: libparabolic/src/controllers/adddownloaddialogcontroller.cpp:160
 msgid "Default"
 msgstr "পূর্বোক্ত"
 
+#: libparabolic/src/controllers/adddownloaddialogcontroller.cpp:171
+msgid "Audio Description"
+msgstr ""
+
 #: libparabolic/src/controllers/mainwindowcontroller.cpp:42
 #: org.nickvision.tubeconverter.qt/src/views/mainwindow.cpp:39
 msgid "Parabolic"
@@ -140,22 +140,18 @@ msgid "Unable to download and install update"
 msgstr ""
 
 #: libparabolic/src/events/downloadprogresschangedeventargs.cpp:21
-#, c++-format
 msgid "{:.2f} GiB/s"
 msgstr ""
 
 #: libparabolic/src/events/downloadprogresschangedeventargs.cpp:25
-#, c++-format
 msgid "{:.2f} MiB/s"
 msgstr ""
 
 #: libparabolic/src/events/downloadprogresschangedeventargs.cpp:29
-#, c++-format
 msgid "{:.2f} KiB/s"
 msgstr ""
 
 #: libparabolic/src/events/downloadprogresschangedeventargs.cpp:33
-#, c++-format
 msgid "{:.2f} B/s"
 msgstr ""
 
@@ -969,7 +965,7 @@ msgid "No Subtitles Available"
 msgstr "শব্দের ভাষা"
 
 #: org.nickvision.tubeconverter.gnome/src/views/adddownloaddialog.cpp:173
-#, fuzzy, c++-format
+#, fuzzy
 msgid "{} items"
 msgstr "একটিও নয়"
 
@@ -1090,7 +1086,6 @@ msgid "Changelog:"
 msgstr "পরিবর্ধন সূচি"
 
 #: org.nickvision.tubeconverter.qt/src/controls/aboutdialog.cpp:39
-#, c++-format
 msgid ""
 "Developers:\n"
 "{}\n"
@@ -1162,7 +1157,7 @@ msgid ""
 msgstr ""
 
 #: org.nickvision.tubeconverter.qt/src/views/adddownloaddialog.cpp:206
-#, fuzzy, c++-format
+#, fuzzy
 msgid "Items ({})"
 msgstr "একটিও নয়"