XPS 15 7590 (nvidia) use open-source driver

[eg-ayoub]

Description of changes

fix for #1092
set hardware.nvidia.open = true; for xps 15 7590
This fixes error induced intentionally, see NixOS/nixpkgs#337289 (comment)

Things done

• Tested the changes in your own NixOS Configuration
• Tested the changes end-to-end by using your fork of nixos-hardware and
  importing it via <nixos-hardware> or Flake input

More info

output from nvidia-smi

$ nvidia-smi 
Fri Aug 30 15:44:25 2024       
+-----------------------------------------------------------------------------------------+
| NVIDIA-SMI 560.35.03              Driver Version: 560.35.03      CUDA Version: 12.6     |
|-----------------------------------------+------------------------+----------------------+
| GPU  Name                 Persistence-M | Bus-Id          Disp.A | Volatile Uncorr. ECC |
| Fan  Temp   Perf          Pwr:Usage/Cap |           Memory-Usage | GPU-Util  Compute M. |
|                                         |                        |               MIG M. |
|=========================================+========================+======================|
|   0  Quadro T2000                   Off |   00000000:01:00.0 Off |                  N/A |
| N/A   51C    P8              2W /   40W |       1MiB /   4096MiB |      0%      Default |
|                                         |                        |                  N/A |
+-----------------------------------------+------------------------+----------------------+
                                                                                         
+-----------------------------------------------------------------------------------------+
| Processes:                                                                              |
|  GPU   GI   CI        PID   Type   Process name                              GPU Memory |
|        ID   ID                                                               Usage      |
|=========================================================================================|
|  No running processes found                                                             |
+-----------------------------------------------------------------------------------------+

[Mic92]

@mergify queue

[mergify]

queue

🛑 The pull request has been removed from the queue default

The merge conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

[Mic92]

To avoid the conflicting option:

Suggested change

	open = lib.mkDefault true;
	open = true;

[BCNelson]

Should we have a way to encode compatibility in a more general way? For instance does the logic to enable and disable the opensource driver belong in the shared gpu code?

[eg-ayoub]

@BCNelson it might be. I just faced this on another one of my machines.
Personally, I think it might cause unexplained breakage for some people.
IIRC, the option's default description shows a condition comparing the package.version to 560. Maybe something along those lines would cause minimal breakage.

[BCNelson]

the option's default description shows a condition comparing the package.version to 560.

@eg-ayoub Where is this I can't seem to find it? All I can find is this line

[BCNelson]

@eg-ayoub I opened another PR #1094 with a bit more of a generic solution

[eg-ayoub]

@BCNelson alright, I'll be closing this then.