Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Number every problem reported by nixpkgs-vet #109

Merged
merged 40 commits into from
Oct 5, 2024
Merged

Number every problem reported by nixpkgs-vet #109

merged 40 commits into from
Oct 5, 2024

Conversation

philiptaron
Copy link
Contributor

Motivation for changes

Description of changes

  • Make a struct for each error reported by nixpkgs-vet
  • Have it Display with the exact same error as previously
  • Change call site to report the specific error rather than use a to_validation closure

This PR is best reviewed commit-by-commit.

@philiptaron
main: use pretty_assertions to make test case failures easier to diag…
a02cae8 
…nose
@philiptaron
Rename NixpkgsProblem to Problem
8902031 
This tool is called `nixpkgs-vet`. Implicitly, every thing it talks about is prefixed by "nixpkgs",
so it doesn't need the explicit prefix.
@philiptaron
NPV-100: attribute is not defined but it should be defined automatically
cb5f8bf 
We have to do a little work to transition the callsite, but it all works.
@philiptaron
NPV-101: attribute is not a derivation
9070097
@philiptaron
NPV-102: attribute uses _internalCallByNamePackageFile
a562e93
@philiptaron
NPV-103: attribute name position cannot be determined
379f051
@philiptaron
Remove ByNameError and ByNameErrorKind
c4c723c
@philiptaron
NPV-104: non-syntactic override of by-name package
a9c236a
@philiptaron
Move read_dir_sorted into structure
d37d322 
It's more about structure than anything else, and it's used here primarily.
@philiptaron
Move BASE_SUBPATH and PACKAGE_NIX_FILENAME to structure
d4092be
@philiptaron
Rename utils.rs to location.rs now that it only contains LineIndex
7cf39eb
@philiptaron
Introduce a Location struct for errors
0c5e390
@philiptaron
NPV-105: by-name override of ill-defined callPackage
d0f229e
@philiptaron
NPV-106: by-name override contains wrong callPackage path
1c99b36
@philiptaron
NPV-107: by-name override contains empty argument
8a2d763
@philiptaron
NPV-108: by-name override contains empty path
661f2d4
@philiptaron
Remove ByNameOverrideError and ByNameOverrideErrorKind
def45b2
@philiptaron
eval: use early returns to dedent by_name_override
96b2d67
@philiptaron
problem: writing new manually is a drag
22c9237 
Let's automate it with the `derive-new` proc macro.
@philiptaron
NPV-109: by-name shard is not a directory
5345db8
@philiptaron
NPV-110: by-name shard is invalid
09c8000
@philiptaron
NPV-111: by-name shard is case-sensitive duplicate
6dd1305
@philiptaron
NPV-120: Nix evaluation failed
de1d3ce
@philiptaron
NPV-121: Nix file contains interpolated path
a5ab0c6
@philiptaron
NPV-122: Nix file contains search path
c51d3ed
@philiptaron
NPV-123: Nix file contains path expression outside of directory
f58eeb8
@philiptaron
NPV-124: Nix file contains unresolvable path expression
7bd10c8
@philiptaron
NPV-125: Package contains symlink pointing outside its directory
65bc10b
@philiptaron
NPV-126: Package contains unresolvable symlink
f5dc1b3
@philiptaron
NPV-140: Package directory is not directory
dee54df
@willbush
Copy link
Member

I'll get a chance to look at this closer tomorrow or this weekend

@philiptaron
Copy link
Contributor Author

Gentle ping to review if you've got the cycles to spend.

@philiptaron philiptaron mentioned this pull request Sep 30, 2024
Merged
13 tasks
@willbush
Copy link
Member

willbush commented Oct 5, 2024 •
edited
Loading

@philiptaron Sorry for the wait! Seems like good changes all around to me. More widespread usage of Into trait and additional crates make a lot of sense. Really appreciate you breaking this commits up (looks like a lot of work). Only nit for future reference fn read_dir_sorted got moved and changed in the same commit; it's easy to miss that it was changed at all. :)

@philiptaron philiptaron merged commit 54a8777 into NixOS:main Oct 5, 2024
3 checks passed
@philiptaron philiptaron deleted the 28-problems branch October 7, 2024 14:12
@infinisil
Copy link
Member

Nice work @philiptaron, and thanks for reviewing @willbush! Sorry that I'm not very available recently 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willbush willbush willbush approved these changes

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@philiptaron @willbush @infinisil