Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python312Packages.datashape: fix #313855

Merged
merged 1 commit into from
May 23, 2024
Merged

python312Packages.datashape: fix #313855

merged 1 commit into from
May 23, 2024

Conversation

Moraxyc
Copy link
Contributor

@Moraxyc Moraxyc commented May 23, 2024 •
edited
Loading

Description of changes

fix build (https://hydra.nixos.org/build/259515370)

ZHF: #309482

The datashape package can not be installed in a python 3.12 environment due to versioneer module which invokes configparser.SafeConfigParser(). This class has been renamed to ConfigParser in Python 3.2. SafeConfigParser then became a deprecated alias and has been removed in Python 3.12.

blaze/datashape#245

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Moraxyc Moraxyc added 0.kind: ZHF Fixes Fixes during the ZHF campaign backport release-24.05 Backport PR automatically labels May 23, 2024
@Moraxyc Moraxyc requested a review from Aleksanaa May 23, 2024 03:24
@Moraxyc Moraxyc force-pushed the py-datashape branch 2 times, most recently from 35e912d to ed4927b Compare May 23, 2024 03:46
fabaff
fabaff reviewed May 23, 2024
View reviewed changes
Copy link
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got a couple of other modules to build with

  postPatch = ''
    # Remove vendorized versioneer.py
    rm versioneer.py
  '';

and build-system = [ ..., versioneer ].

@Moraxyc
Copy link
Contributor Author

Moraxyc commented May 23, 2024

thx!
It works now

@Moraxyc Moraxyc changed the title python312Packages.datashape: disable on Python 3.12 python312Packages.datashape: fix May 23, 2024
@Moraxyc Moraxyc requested a review from fabaff May 23, 2024 09:01
@fabaff
Copy link
Member

fabaff commented May 23, 2024

Result of nixpkgs-review pr 313855 run on x86_64-linux 1

6 packages built:
  • python311Packages.datashader
  • python311Packages.datashader.dist
  • python311Packages.datashape
  • python311Packages.datashape.dist
  • python312Packages.datashape
  • python312Packages.datashape.dist

fabaff
fabaff approved these changes May 23, 2024
View reviewed changes
Copy link
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good to me.

risicle
risicle approved these changes May 23, 2024
View reviewed changes
Copy link
Contributor

@risicle risicle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. nixpkgs-review happy, macos 12 x86_64 & nixos x86_64

@risicle risicle merged commit e9d42f8 into NixOS:master May 23, 2024
25 of 27 checks passed
@github-actions GitHub Actions
Copy link
Contributor

Successfully created backport PR for release-24.05:

@github-actions github-actions bot mentioned this pull request May 23, 2024
Merged
1 task
@Moraxyc Moraxyc deleted the py-datashape branch May 23, 2024 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabaff fabaff fabaff approved these changes

@risicle risicle risicle approved these changes

@Aleksanaa Aleksanaa Awaiting requested review from Aleksanaa

Assignees
No one assigned
Labels
0.kind: ZHF Fixes Fixes during the ZHF campaign 6.topic: python 8.has: clean-up 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12.approvals: 1 backport release-24.05 Backport PR automatically
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Moraxyc @fabaff @risicle