Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libminc: 2.4.03 -> unstable-2020-07-17 #93675

Merged
merged 12 commits into from
Oct 7, 2020
Merged

Conversation

bcdarwin
Copy link
Member

@bcdarwin bcdarwin commented Jul 22, 2020

and update reverse dependencies accordingly

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bcdarwin
Copy link
Member Author

bcdarwin commented Jul 30, 2020

Getting some weird resource temporarily unavailable test failures on nix.ci but nixpkgs-review pr succeeds locally; probably some OfBorg resource limit?

36/50 Test #45: minc2-slice-test .................***Failed    0.02 sec
/build/source/libsrc/netcdf_convenience.c:573 (from miopen): Unable to open file '/build/source/build/testdir/3D_minc2_int.mnc'
/build/source/build/testdir/3D_minc2_int.mnc: Resource temporarily unavailable
/build/source/libsrc2/volume.c:1390 (from miopen): Unable to open file '/build/source/build/testdir/3D_minc2_int.mnc'
can't open /build/source/build/testdir/3D_minc2_int.mnc, error -1

@bcdarwin
Copy link
Member Author

Rebased onto master and resolved breakage from another PR (#91071).

Copy link
Member

@lheckemann lheckemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, upstream could do with some more releases :D

That aside, LGTM.

@lheckemann
Copy link
Member

That is indeed an, uh, interesting failure on ofborg. Let's just kick it.

@ofborg build EBTKS bicgl bicpl conglomerate inormalize minc_tools mni_autoreg n3 oobicpl

@bcdarwin
Copy link
Member Author

libminc tests are still weirdly failing, so I've disabled parallel building -- perhaps that will help.

@bcdarwin
Copy link
Member Author

bcdarwin commented Oct 6, 2020

@lheckemann turns out the tests can't be run in parallel (and enableParallelBuilding doesn't control ctest); see BIC-MNI/libminc#110. Anyway, good to go now.

@lheckemann lheckemann merged commit a25bd66 into NixOS:master Oct 7, 2020
@bcdarwin bcdarwin deleted the update-libminc branch October 7, 2020 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants