-
-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
libminc: 2.4.03 -> unstable-2020-07-17 #93675
Conversation
Getting some weird
|
ad2d095
to
ae7b398
Compare
150181d
to
b99b4c2
Compare
Rebased onto master and resolved breakage from another PR (#91071). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, upstream could do with some more releases :D
That aside, LGTM.
That is indeed an, uh, interesting failure on ofborg. Let's just kick it. @ofborg build EBTKS bicgl bicpl conglomerate inormalize minc_tools mni_autoreg n3 oobicpl |
b99b4c2
to
cbecc75
Compare
|
cbecc75
to
7aa0753
Compare
- propagate hdf5 and netcdf since essentially every reverse dep of libminc depends on these - switch to default HDF5 from 1.8.x series - one resolved test failure and one new error (less concerning than before)
- update LIBMINC_DIR and EBTKS_DIR due to CMake updates in those packages
- no longer needed as `libminc` has been updated to use the default hdf5
7aa0753
to
95439a7
Compare
@lheckemann turns out the tests can't be run in parallel (and |
and update reverse dependencies accordingly
Motivation for this change
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)