Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List all files in the regular review #6

Merged
merged 1 commit into from
Apr 25, 2024
Merged

Conversation

infinisil
Copy link
Member

@infinisil infinisil commented Apr 24, 2024

This allows linking to each file directly, which makes the regular monthly reviews easier.

Before:

  • /README.md: @some_user
  • /CONTRIBUTING.md: @some_user
  • /LICENSE: @some_user
  • /.github/CODEOWNERS: @some_user
  • /.github/workflows: @some_user
  • /scripts: @some_user
  • /doc/org-repo.md: @some_user
  • /doc/discourse.md: @some_user
  • /doc/github.md: @some_user
  • /doc/matrix.md: @some_user
  • /doc/moderation.md: @some_user
  • /doc/nixos-releases.md: @some_user
  • /doc/resources.md: @some_user
  • /doc/rfcs.md: @some_user
  • /doc/teams.md: @some_user

After:

With these changes we could also easily consider limiting the checkboxes to just files in doc or Markdown files in the future. Though I'd say let's leave it at all files for now.

@infinisil infinisil requested a review from zimbatm as a code owner April 24, 2024 20:13
This allows linking to each file directly, which makes reviews easier.
Copy link
Member

@zimbatm zimbatm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@infinisil infinisil merged commit 9c1ee55 into main Apr 25, 2024
2 checks passed
@infinisil infinisil deleted the review-list-files branch April 25, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants