-
Notifications
You must be signed in to change notification settings - Fork 688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test .NET 9.0.1xx in the Dotnet integration tests #6063
Open
nkolev92
wants to merge
19
commits into
dev
Choose a base branch
from
dev-nkolev92-testnet9indotnettests
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkolev92
changed the title
Test .NET 9 in Dotnet integration tests
Test .NET 9.0.1xx in the Dotnet integration tests
Sep 27, 2024
I think this is something we should consider patching release-6.12.x with, ensuring our tests are current |
zivkan
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Related: https://github.com/NuGet/Client.Engineering/issues/3025
Description
Similar to #6011.
Updating the tested .NET SDK to Net 9. Note that in the past, we'd update both the test framework and the .NET SDK being tested. I don't think this is necessary, since this is a full test where we patch to the SDK which comes with its own runtime and all.
Note that I consolidated the places where we'd need to make changes to get these tests passing.
PR Checklist
Added testsLink to an issue or pull request to update docs if this PR changes settings, environment variables, new feature, etc.