Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test .NET 9.0.1xx in the Dotnet integration tests #6063

Open
wants to merge 19 commits into
base: dev
Choose a base branch
from

Conversation

nkolev92
Copy link
Member

@nkolev92 nkolev92 commented Sep 27, 2024

Bug

Related: https://github.com/NuGet/Client.Engineering/issues/3025

Description

Similar to #6011.

Updating the tested .NET SDK to Net 9. Note that in the past, we'd update both the test framework and the .NET SDK being tested. I don't think this is necessary, since this is a full test where we patch to the SDK which comes with its own runtime and all.

Note that I consolidated the places where we'd need to make changes to get these tests passing.

PR Checklist

  • Meaningful title, helpful description and a linked NuGet/Home issue
  • Added tests
  • Link to an issue or pull request to update docs if this PR changes settings, environment variables, new feature, etc.

@nkolev92 nkolev92 changed the title Test .NET 9 in Dotnet integration tests Test .NET 9.0.1xx in the Dotnet integration tests Sep 27, 2024
@nkolev92 nkolev92 marked this pull request as ready for review September 27, 2024 17:22
@nkolev92 nkolev92 requested a review from a team as a code owner September 27, 2024 17:22
@nkolev92
Copy link
Member Author

nkolev92 commented Sep 27, 2024

I think this is something we should consider patching release-6.12.x with, ensuring our tests are current

@nkolev92 nkolev92 mentioned this pull request Sep 27, 2024
3 tasks
@nkolev92 nkolev92 marked this pull request as draft September 27, 2024 18:43
@nkolev92 nkolev92 marked this pull request as ready for review September 30, 2024 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants