Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

11.0 fix consolidation pl accounts #21

Open
wants to merge 7 commits into
base: 11.0
Choose a base branch
from
Open

11.0 fix consolidation pl accounts #21

wants to merge 7 commits into from

Conversation

grindtildeath
Copy link
Contributor

@grindtildeath grindtildeath commented Jun 14, 2019 •
edited
Loading

Includes:

TODO:

  • Improve tests adding a move in the previous year
  • Improve UI

grindtildeath and others added 6 commits June 3, 2019 10:27
@grindtildeath
Improve performance with direct SQL on consolidation flag
355587f 
As the consolidated flag is a technical field that is only used during the consolidation
process to distinct move lines that are already processed from others, we can safely
bypass the ORM to avoid costly overrides in custom modules that are installed.
@grindtildeath
Improve error message when reversing existing moves
525d8d7
@grindtildeath
[IMP] Add test to check created rvered move lines on consolidation
69da56a
@grindtildeath
Fix test on reversed moves
c2d1372
@grindtildeath
[FIX] Do not post reversed consolidation entries
e5ece57
@grindtildeath
Ensure reversals of conso entries are regenerated after deletion
d86cbd9
@coveralls
Copy link

coveralls commented Jun 14, 2019 •
edited
Loading

Coverage Status

Coverage decreased (-1.08%) to 31.099% when pulling 9e0b140 on grindtildeath:11.0_fix_consolidation_pl_accounts into e08dcb2 on OCA:11.0.

@grindtildeath grindtildeath force-pushed the 11.0_fix_consolidation_pl_accounts branch from d34a597 to 9e0b140 Compare June 17, 2019 08:47
i-vyshnevska
i-vyshnevska reviewed Jun 17, 2019
View reviewed changes
account_consolidation/wizard/consolidation_consolidate.py
# As reversed move have the reversal_id link, and we select only the
# moves not having it in the search above, we can be sure that only the
# last consolidation moves will be reversed
moves_to_reverse.write({'to_be_reversed': True})
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this still the case? shouldn't we relay only on reversal_id in search, or we should also override unlink to raise flag

TDu
TDu approved these changes Jun 17, 2019
View reviewed changes
Copy link
Member

@TDu TDu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@i-vyshnevska i-vyshnevska i-vyshnevska left review comments

@TDu TDu TDu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@grindtildeath @coveralls @TDu @i-vyshnevska