-
-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[14.0][MIG] account_consolidation: Migration to 14.0 #38
Conversation
cf758ce
to
ed24e8a
Compare
bc26f87
to
3de125f
Compare
39c7ca4
to
3152616
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[FUNCIONAL TEST] NOT APPROVED
There is a problem with calculating the correct currency conversion rate.
Follow the steps to perform the test.
1.Create Jornal Entries in the subsidiaries (A and B)
I ran the same scenario in the v.12 application, which suggests that the flaw doesn't occur in the v12 application.
Having the account_consolidation module is interesting thing, since the Consolidation Module has been moved to the EE version. I have curious questions:
Thanks |
Thank you for expressing your suggestions regarding the account_consolidation module. Currently, our focus is on the migration process. However, I appreciate your input, and I encourage you to create an issue on the account-consolidation repository for further discussion. |
3152616
to
8312658
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ping @OCA/accounting-maintainers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Currently translated at 98.1% (104 of 106 strings) Translation: account-consolidation-12.0/account-consolidation-12.0-account_consolidation Translate-URL: https://translation.odoo-community.org/projects/account-consolidation-12-0/account-consolidation-12-0-account_consolidation/pt_BR/
Currently translated at 89.6% (95 of 106 strings) Translation: account-consolidation-12.0/account-consolidation-12.0-account_consolidation Translate-URL: https://translation.odoo-community.org/projects/account-consolidation-12-0/account-consolidation-12-0-account_consolidation/es/
Currently translated at 9.4% (10 of 106 strings) Translation: account-consolidation-12.0/account-consolidation-12.0-account_consolidation Translate-URL: https://translation.odoo-community.org/projects/account-consolidation-12-0/account-consolidation-12-0-account_consolidation/hr/
Currently translated at 100.0% (106 of 106 strings) Translation: account-consolidation-12.0/account-consolidation-12.0-account_consolidation Translate-URL: https://translation.odoo-community.org/projects/account-consolidation-12-0/account-consolidation-12-0-account_consolidation/pt_BR/
Currently translated at 100.0% (106 of 106 strings) Translation: account-consolidation-12.0/account-consolidation-12.0-account_consolidation Translate-URL: https://translation.odoo-community.org/projects/account-consolidation-12-0/account-consolidation-12-0-account_consolidation/pt/
06e5139
to
0746718
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I tried to reexecute on a finalized month, the move was not reversed. You can see it on runboat.
33fc00a
to
9808f86
Compare
BTW, about the renaiming, can you use the following script in order to refactor all history and avoid the renaming commit? Otherwise, history will be lost on next migration:
|
9808f86
to
63ef556
Compare
There was some conflict when I went to squash and script, so to be more organized I opened a new pull request: [14.0] account_consolidation_oca: add new module |
cc @marcelsavegnago
Adapted some functionalities to be used as auto_post instead of the no longer present auto_reverse in addons account.
Due to pylint detecting duplicate ID for the demo consolidation_company when accessing the consolidation account, please go to:
Below is a screenshot of how it should look like.