Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][IMP] account_financial_report: Several improvements #1081

Draft
wants to merge 2 commits into
base: 16.0
Choose a base branch
from

Conversation

rousseldenis
Copy link
Sponsor

This is intended to trigger a discussion on how to cover the filtering on analytic accounts without storing the analytic accounts on move lines.

  • Remove analytic accounts on move line
  • Enhance filters visibility

@rousseldenis rousseldenis marked this pull request as draft October 20, 2023 09:16
@rousseldenis
Copy link
Sponsor Author

Copy link
Member

@flotho flotho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

easy code review,
Thanks LGTM

@rousseldenis rousseldenis marked this pull request as ready for review November 2, 2023 10:16
@rousseldenis rousseldenis marked this pull request as draft November 2, 2023 10:17
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

If you open a filter tab, you cannot identify the field position. So,
display the label in front of it.
On account.move.line, don't store here the analytic accounts as it can be
bulky (especially the init on big database).
@rousseldenis rousseldenis force-pushed the 16.0-imp-account-financial-report-dro branch from 441b82d to c6c4dac Compare April 2, 2024 14:12
@rousseldenis
Copy link
Sponsor Author

rousseldenis commented Apr 2, 2024

@yajo Nevertheless your comment #1105 (comment), this should be addressed in a better elegant solution than adding a field here.

Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Sep 29, 2024
@pedrobaeza
Copy link
Member

Aren't now a native analytic search included in core?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ready to merge stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants