[14.0][IMP] account_financial_report: general ledger account range #1165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WesleyOliveira98
force-pushed
the
14.0-account_financial_report-imp-general-ledger-account-range
branch
from
18cfd33
to
9f3cddb
Compare
|
It was necessary to search for the last appearance of the end_range code in case you have the same account code in two or more different companies, the index method returns the first appearance of the code, we also added some unit tests |
|
ping @OCA/accounting-maintainers |
1 similar comment
|
ping @OCA/accounting-maintainers |
marcelsavegnago
approved these changes
Jun 3, 2024
|
This PR has the |
|
ping @WesleyOliveira98 |
WesleyOliveira98
force-pushed
the
14.0-account_financial_report-imp-general-ledger-account-range
branch
from
9f3cddb
to
bad8897
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improvement allows filtering accounts by range in the General Ledger for chart of accounts that use a dotted format, such as
1.1.1.01. Currently, this functionality is not available because accounts with dots fail theisdigit()check.Brazilian Chart of Accounts Example (https://github.com/OCA/l10n-brazil/blob/14.0/l10n_br_coa_simple/data/account.account.template.csv)
General Ledger with Brazilian Accounts
When attempting to remove dots from accounts and compare them as integers using the
filteredmethod, the filter does not apply correctly if the accounts have different numbers of digits (when we use thesearchmethod, this isn't a problem). So, we implemented a solution where we search for the position of each account in the chart of accounts, finding the position of thestart_rangeaccount and theend_rangeaccount, and then retrieve the accounts between these positions.cc: @marcelsavegnago @kaynnan @Matthwhy