Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][OU] account_financial_report: migration script #1188

Open
wants to merge 1 commit into
base: 16.0
Choose a base branch
from
Open

[16.0][OU] account_financial_report: migration script #1188

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 38 additions & 0 deletions account_financial_report/migrations/16.0.1.0.0/pre-migration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
# Copyright 2024 Tecnativa - David Vidal
# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html).
from openupgradelib import openupgrade


@openupgrade.migrate()
def migrate(env, version):
"""Pre-create analytic_account_ids m2m relation and pre-fill it"""
env.cr.execute(
"""
CREATE TABLE account_analytic_account_account_move_line_rel (
account_move_line_id INTEGER NOT NULL,
account_analytic_account_id INTEGER NOT NULL,
PRIMARY KEY(account_move_line_id, account_analytic_account_id)
);
COMMENT ON TABLE account_analytic_account_account_move_line_rel IS
'RELATION BETWEEN account_move_line AND account_analytic_account';
CREATE INDEX ON account_analytic_account_account_move_line_rel (
account_analytic_account_id,account_move_line_id
);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The FK are missing here, isn't it? Why not do it the trick of creating a fake table on pre, and then remove it on post to then call the ORM that creates it correctly?

You can find an example in v16 here:

https://github.com/OCA/OpenUpgrade/blob/16.0/openupgrade_scripts/scripts/hr_skills/16.0.1.0/post-migration.py

"""
)
openupgrade.logged_query(
env.cr,
"""
INSERT INTO account_analytic_account_account_move_line_rel (
account_move_line_id, account_analytic_account_id
)
SELECT
aml.id AS account_move_line_id,
jsonb_each.key::int AS account_analytic_account_id
FROM
account_move_line aml,
jsonb_each(aml.analytic_distribution) AS jsonb_each
WHERE
aml.analytic_distribution IS NOT NULL;
""",
)
Loading