Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][FIX] account_payment_order: Assure partner bank account in payments #1348

Merged

Commits on Sep 16, 2024

  1. [FIX] account_payment_order: Assure partner bank account in payments

    On certain v16 instances, although the partner bank account that is
    being pre-set in the account.payment creation values dictionary:
    
    https://github.com/OCA/bank-payment/blob/fc7783669f40d85/account_payment_order/models/account_payment_line.py#L206
    
    it's being marked as dirty (it's a computed writable field), and thus,
    being recomputed before being saved, getting an invalid value (on
    direct debits, the company's bank account).
    
    The triggers that lead to this situation are unknown due to the low
    level where it's happening and the tons of interactions being taken in
    place, so the best way to deal with this is to override the compute
    method that computes this value, so even if the field is recomputed, it
    gets the correct value.
    
    Let's be pragmatic...
    
    TT50804
    pedrobaeza committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    ecee08a View commit details
    Browse the repository at this point in the history