Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][IMP] account_payment_mode: change type of payment_mode.note field #1360

Open
wants to merge 1 commit into
base: 16.0
Choose a base branch
from

Conversation

clementelabore
Copy link

Change type of payment_mode.note from Text to Html
This to improve display on Invoice document

@pedrobaeza pedrobaeza added this to the 16.0 milestone Sep 26, 2024
@pedrobaeza
Copy link
Member

I see this improvement as something good, but you should provide a migration script for converting previous content to HTML. There's an openupgradelib method for that.

@clementelabore
Copy link
Author

I hope it was the right way to do it ;)

@pedrobaeza
Copy link
Member

I'm afraid not. That's a hook, not a migration script. A sample (not with the same change though): https://github.com/OCA/contract/tree/16.0/contract/migrations

@clementelabore clementelabore force-pushed the pr-account-payment-mode-note-html branch from d4ecf1b to 7984c5c Compare October 1, 2024 13:24
@clementelabore
Copy link
Author

it should be ok when OCA/openupgradelib#384 will be merged

@pedrobaeza
Copy link
Member

Please squash commits into one

@clementelabore clementelabore force-pushed the pr-account-payment-mode-note-html branch from 41fa745 to 7a6f72c Compare October 3, 2024 14:49
@clementelabore clementelabore force-pushed the pr-account-payment-mode-note-html branch from 7a6f72c to 1dd87a0 Compare October 3, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants