[MIG] [16.0] pos_payment_change #929

julenfl · 2023-02-21T08:17:48Z

PR for migration from v15.0 to v16.0

related task: #849

- Black python code - OCA Convention - Add tests - add configuration on pos.config, with two option 'refund' or 'update' - The 'refund' option makes the module compatible with (French) certification - make the module compatible with pos_order_return

…on PoS Order(s) to know the history of the payments

…ontrol ; [ADD] display old payment lines

Currently translated at 100.0% (31 of 31 strings) Translation: pos-12.0/pos-12.0-pos_payment_change Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_payment_change/es/

add new line Pylint fix pylint

Currently translated at 100.0% (33 of 33 strings) Translation: pos-12.0/pos-12.0-pos_payment_change Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_payment_change/es/

Currently translated at 100.0% (33 of 33 strings) Translation: pos-12.0/pos-12.0-pos_payment_change Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_payment_change/de/

A cash payment method must have a cash journal.

legalsylvain · 2023-02-22T12:02:30Z

/ocabot migration pos_payment_change

PierrickBrun · 2023-03-06T12:53:40Z

Hi @julenfl ,

I'm interested in migrating this module too, do you know when you will continue/finish working on this ?

I can take it from here if this fits you.

I've done a quick test and noticed the following:

small problem with float_compare: I've sent you a PR to fix it
Apparently the pos closing button/screen has disappeared (maybe this is linked to something else in my dev env)

[FIX] use float_compare to compare floats

julenfl · 2023-03-16T12:21:27Z

Hi @julenfl ,

I'm interested in migrating this module too, do you know when you will continue/finish working on this ?

I can take it from here if this fits you.

I've done a quick test and noticed the following:

small problem with float_compare: I've sent you a PR to fix it

Apparently the pos closing button/screen has disappeared (maybe this is linked to something else in my dev env)

Hi @PierrickBrun

First I apologize for not answering you. I have already accepted your PR, now I am working hard with other migrations. If you want you can continue with the migration, I can accept the PR or do it as you want.

thanks

victor-champonnois

Functional test OK

victor-champonnois · 2023-04-19T13:57:48Z

Note : there is a weird behavior when clicking to edit the old payment line it opens a wizard that doesn't make sense

The bug already exists in version 14 though, so I guess it's not required to fix it here.

victor-champonnois

Code review LGTM

RodrigoBM · 2023-05-10T11:51:05Z

@legalsylvain can you merge it, thanks

legalsylvain · 2023-05-10T13:48:18Z

pos_payment_change/wizards/view_pos_payment_change_wizard.xml

+                    <field name="amount_total" invisible="1" />
+                    <field name="old_line_ids" colspan="4">
+                        <tree>
+                            <field name="old_payment_method_id" />


Suggested change

<field name="old_payment_method_id" />

<field name="old_payment_method_id" widget="selection"/>

that should do the job, regarding @victor-champonnois remarks.

I have added the changes that you have requested in the PR, thanks

legalsylvain · 2023-05-10T13:48:59Z

pos_payment_change/wizards/view_pos_payment_change_wizard.xml

+                        <tree editable="bottom">
+                            <field
+                                name="new_payment_method_id"
+                                options="{'no_open': True, 'no_create_edit': True}"


Suggested change

options="{'no_open': True, 'no_create_edit': True}"

widget="selection"

same here I guess. Don't you think ?

I have added the changes that you have requested in the PR, thanks

OCA-git-bot · 2023-05-10T14:36:32Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

OCA-git-bot · 2023-05-10T14:36:34Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

legalsylvain · 2023-05-17T11:58:21Z

/ocabot merge nobump

Thanks for your contribution.

OCA-git-bot · 2023-05-17T11:58:33Z

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-929-by-legalsylvain-bump-nobump, awaiting test results.

OCA-git-bot · 2023-05-17T12:07:12Z

Congratulations, your PR was merged at 41c1d71. Thanks a lot for contributing to OCA. ❤️

legalsylvain and others added 17 commits February 20, 2023 23:08

[IMP] use refund() to resale order (in 'refund' mode) ; [ADD] a note …

a0e7dc7

…on PoS Order(s) to know the history of the payments

[FIX] error in balance computation if change is done during closing c…

7278548

…ontrol ; [ADD] display old payment lines

Update __manifest__.py

18555d0

[FIX] access to ir.module.module should be done with sudo

07ff79a

Added translation using Weblate (Spanish)

d0c2422

Translated using Weblate (Spanish)

84b82b9

Currently translated at 100.0% (31 of 31 strings) Translation: pos-12.0/pos-12.0-pos_payment_change Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_payment_change/es/

Use currency and monetary so that rounding will be done by the ORM*

4facd60

add new line Pylint fix pylint

more fix pyilint

976caa9

Translated using Weblate (Spanish)

f3eb510

Currently translated at 100.0% (33 of 33 strings) Translation: pos-12.0/pos-12.0-pos_payment_change Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_payment_change/es/

Added translation using Weblate (German)

551edc9

Translated using Weblate (German)

8283dba

Currently translated at 100.0% (33 of 33 strings) Translation: pos-12.0/pos-12.0-pos_payment_change Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_payment_change/de/

[IMP] pos_payment_change: isort, black, prettier.

1086773

[MIG] Migrate module pos_payment_change to v14.

dd1f953

[FIX] pos_payment_change: fix test

006d6e6

A cash payment method must have a cash journal.

[MIG]pos_payment_change: Migration to 15.0

0292213

[IMP] pos_payment_change: pre-commit stuff

a08b348

julenfl force-pushed the 16.0-mig-pos_payment_change branch from 40eed6f to d30d774 Compare February 21, 2023 08:19

julenfl mentioned this pull request Feb 21, 2023

Migration to version 16.0 #849

Open

37 tasks

julenfl force-pushed the 16.0-mig-pos_payment_change branch 2 times, most recently from dea747e to 16a66fa Compare February 22, 2023 11:52

OCA-git-bot added this to the 16.0 milestone Feb 22, 2023

julenfl added 2 commits February 22, 2023 17:23

[WIP] pos_payment_change: Migration to 16.0

c7b097d

[FIX] the method _check_pos_session_balance is deleted in point_of_sale

bfd1971

julenfl force-pushed the 16.0-mig-pos_payment_change branch from c4582f7 to bfd1971 Compare February 22, 2023 16:24

julenfl changed the title ~~[MIG] [16.0] pos_payment_change~~ [WIP] [16.0] pos_payment_change Feb 22, 2023

[FIX] use float_compare to compare floats

4fbf636

Merge pull request #1 from akretion/16.0-mig-pos_payment_change

02ba9cb

[FIX] use float_compare to compare floats

victor-champonnois approved these changes Apr 19, 2023

View reviewed changes

victor-champonnois reviewed Apr 19, 2023

View reviewed changes

julenfl changed the title ~~[WIP] [16.0] pos_payment_change~~ [MIG] [16.0] pos_payment_change Apr 20, 2023

RodrigoBM approved these changes May 10, 2023

View reviewed changes

OCA-git-bot added the approved label May 10, 2023

legalsylvain reviewed May 10, 2023

View reviewed changes

julenfl force-pushed the 16.0-mig-pos_payment_change branch from c6aa9df to d0cf40e Compare May 10, 2023 14:30

OCA-git-bot added the ready to merge label May 10, 2023

[MIG] pos_payment_change: modification wizard view, add widget selection

82e3147

julenfl force-pushed the 16.0-mig-pos_payment_change branch from d0cf40e to 82e3147 Compare May 17, 2023 11:44

julenfl requested a review from legalsylvain May 17, 2023 11:49

OCA-git-bot added the bot is merging ⏳ label May 17, 2023

OCA-git-bot merged commit 8afb0ff into OCA:16.0 May 17, 2023

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels May 17, 2023

RodrigoBM deleted the 16.0-mig-pos_payment_change branch May 17, 2023 12:56

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[MIG] [16.0] pos_payment_change #929

[MIG] [16.0] pos_payment_change #929

julenfl commented Feb 21, 2023

legalsylvain commented Feb 22, 2023

PierrickBrun commented Mar 6, 2023 •

edited

Loading

julenfl commented Mar 16, 2023 •

edited

Loading

victor-champonnois left a comment

victor-champonnois commented Apr 19, 2023

victor-champonnois left a comment

RodrigoBM commented May 10, 2023

legalsylvain May 10, 2023

julenfl May 10, 2023

legalsylvain May 10, 2023

julenfl May 10, 2023

OCA-git-bot commented May 10, 2023

OCA-git-bot commented May 10, 2023

legalsylvain commented May 17, 2023

OCA-git-bot commented May 17, 2023

OCA-git-bot commented May 17, 2023

	<field name="old_payment_method_id" />
	<field name="old_payment_method_id" widget="selection"/>

	options="{'no_open': True, 'no_create_edit': True}"
	widget="selection"

[MIG] [16.0] pos_payment_change #929

[MIG] [16.0] pos_payment_change #929

Conversation

julenfl commented Feb 21, 2023

legalsylvain commented Feb 22, 2023

PierrickBrun commented Mar 6, 2023 • edited Loading

julenfl commented Mar 16, 2023 • edited Loading

victor-champonnois left a comment

Choose a reason for hiding this comment

victor-champonnois commented Apr 19, 2023

victor-champonnois left a comment

Choose a reason for hiding this comment

RodrigoBM commented May 10, 2023

legalsylvain May 10, 2023

Choose a reason for hiding this comment

julenfl May 10, 2023

Choose a reason for hiding this comment

legalsylvain May 10, 2023

Choose a reason for hiding this comment

julenfl May 10, 2023

Choose a reason for hiding this comment

OCA-git-bot commented May 10, 2023

OCA-git-bot commented May 10, 2023

legalsylvain commented May 17, 2023

OCA-git-bot commented May 17, 2023

OCA-git-bot commented May 17, 2023

PierrickBrun commented Mar 6, 2023 •

edited

Loading

julenfl commented Mar 16, 2023 •

edited

Loading