Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0] [MIG] mail_quoted_reply: Migration to 16.0 #1267

Closed
wants to merge 1 commit into from

Conversation

mdurepos
Copy link

Rewrote JavaScript to match major changes in 15.0->16.0 transition. Prior code relied on methods that no longer exist. New code patches the multiple models in @mail/models to mimic the code present for the "reply to" MessageAction.

This version also fixes a bug in which the quoted reply button appeared on notes as well as emails and sometimes duplicated itself repeatedly after mouseover events.

Rewrote JavaScript to match major changes in 15.0->16.0 transition.
Prior code relied on methods that no longer exist. New code patches the
multiple models in @mail/models to mimic the code present for the
"reply to" MessageAction.

This version also fixes a bug in which the quoted reply button appeared
on notes as well as emails and sometimes duplicated itself repeatedly
after mouseover events.
@mdurepos mdurepos changed the title [REL] mail_quoted_reply: Migrate JavaScript to 16.0 [16.0] [MIG] mail_quoted_reply: Migration to 16.0 Dec 12, 2023
@grindtildeath
Copy link
Contributor

Hello @mdurepos

Thanks for the effort, but you should follow the guidelines for migrations and keep previously existing commits.

By the way, there's already an open PR for this module that is linked in the migration to 16.0 issue, so I would suggest we close this one in favour of merging #1165 , and you can still provide fixes afterwards if still needed.

@rafaelbn rafaelbn added this to the 16.0 milestone Jan 9, 2024
@rafaelbn
Copy link
Member

rafaelbn commented Jan 9, 2024

Closing as already merged the migration

@rafaelbn rafaelbn closed this Jan 9, 2024
@mdurepos
Copy link
Author

mdurepos commented Jan 9, 2024

Hello @mdurepos

Thanks for the effort, but you should follow the guidelines for migrations and keep previously existing commits.

By the way, there's already an open PR for this module that is linked in the migration to 16.0 issue, so I would suggest we close this one in favour of merging #1165 , and you can still provide fixes afterwards if still needed.

Thanks for the pointers and especially the link to the migration guidelines. I will follow up if anything is broken in the recently migrated version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants