Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD] REPLACE OR REMOVE HREF AND COMPANY NAME #1437

Open
wants to merge 1 commit into
base: 17.0
Choose a base branch
from

Conversation

elhamdaoui
Copy link

@elhamdaoui elhamdaoui commented Aug 28, 2024

ADD this param config if we want replace "Odoo" by our company name and "href :..odoo.com" by our company website url
KEY : mail_debrand.action
VALUE : replace

@OCA-git-bot
Copy link
Contributor

Hi @pedrobaeza, @joao-p-marques,
some modules you are maintaining are being modified, check this out!

@pedrobaeza
Copy link
Member

I think that should be another module mail_rebrand instead of mail_debrand.

@elhamdaoui
Copy link
Author

I think that should be another module mail_rebrand instead of mail_debrand.

These changes do not affect the current behavior. The module can serve both roles: debranding and rebranding. However, if you want to replace the terms, you can manually add the config parameter mail_debrand.action=replace.

If we add a new module alongside mail_rebrand, both modules must not be installed at the same time to avoid conflicts. Otherwise, we would need to override the method, which could add complexity. A better approach would be to use the same module and differentiate between debranding and rebranding using a configuration parameter. Instead of mail_debrand.action=replace, we could use mail_debrand.action=debrand or mail_debrand.action=rebrand to clearly specify the desired action.

@pedrobaeza
Copy link
Member

I was thinking in doing mail_rebrand depending of mail_debrand. Why separate both? For not adding maintenance burden to the maintainers of this module if they don't want this feature.

Another thing: the commit message must follow the commit message guidelines: https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst#commit-message (and please about all in upper).

@elhamdaoui
Copy link
Author

elhamdaoui commented Aug 29, 2024

I was thinking in doing mail_rebrand depending of mail_debrand. Why separate both? For not adding maintenance burden to the maintainers of this module if they don't want this feature.

Another thing: the commit message must follow the commit message guidelines: https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst#commit-message (and please about all in upper).

We cannot use the current version of the mail_debrand module with the mail_rebrand module because mail_debrand completely removes "< a >" with href="*.odoo.com" links. To make them compatible, mail_debrand needs to be updated so that it does not remove these links when mail_rebrand is installed. This modification will enable both modules to work together as intended.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants